| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@willingc Is there anyone from the documentation experts who may be interested in helping with this? |
Sorry, something went wrong.
|
@Fidget-Spinner Are you available to help here? |
Sorry, something went wrong.
|
@iritkatriel I'm happy to help if @Fidget-Spinner is unavailable. I'm assuming you wish for some help to resolve whatever is causing the doc build to error. |
Sorry, something went wrong.
There was a problem hiding this comment.
Irit, this looks good. Looking into the keyword errors.
Sorry, something went wrong.
Thank you. Not just the formatting error, also a fresh reader who can see if it’s clear and consistent with the documentation style, and whether things are where they belong and at the right level of detail. |
Sorry, something went wrong.
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
|
@iritkatriel I think the tone and content are well done. I need to drop for the evening but feel free to merge if the build error resolves. Ping me in the morning if you get stuck on that. Thanks! |
Sorry, something went wrong.
|
Hi @iritkatriel, you need to create a label/anchor (I forgot the term) for except_star. See line 221-223 of compound_stmts.rst for an example. Adding a .._except_star: under the try, except, finally labels should be sufficient. For some reason, keyword labels must be placed preceding a title, even though rST supports arbitrary anchors normally. See https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-ref for more info. |
Sorry, something went wrong.
|
Thank you @willingc and @Fidget-Spinner , it's looking good now. I will give @gvanrossum and @1st1 and anyone else a chance to review before merging. There isn't any rush with this - the early users we have now already read the PEP. |
Sorry, something went wrong.
There was a problem hiding this comment.
Wow! This is the first time I'm reading about PEP 654 in more detail, and I did not realize it was this powerful!
Speaking from the perspective of a newbie, I understood what you wrote. The tutorial and language reference is very clear to me.
Sorry, something went wrong.
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
…that rest is not exactly subgroup(not condition)
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
I'm happy to take comments related to .__note__ over on my PEP 678 draft 😁 |
Sorry, something went wrong.
|
Shall I merge this? It might be nice to have the documentation there when except* is released in the next alpha. |
Sorry, something went wrong.
|
@iritkatriel Prior to merging, can you recap any outstanding next actions needed in a message here. Thanks! |
Sorry, something went wrong.
|
I believe this PR now describes the way exception groups and except* work, and is consistent with PEP654. The new __note__ field on exception is the subject of PEP678, which is still in draft stage. The doc here describes the current implementation, which is consistent with the PEP. Any changes/reversion following the PEP678 discussions will be made in the code and the doc at the same time. |
Sorry, something went wrong.
|
I could also split out the __note__ section into a separate PR and merge only the PEP654 stuff for now if that works better. |
Sorry, something went wrong.
Yeah, let's keep __note__ undocumented until its PEP has been approved. |
Sorry, something went wrong.
|
Thank you everyone! The notes section is in this draft PR #30441. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
https://bugs.python.org/issue45292