FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. by iritkatriel · Pull Request #30289 · python/cpython · GitHub

/ cpython Public

bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. - #30289

Merged
iritkatriel merged 9 commits into
python:mainfrom
iritkatriel:simplify-except-star
Jan 2, 2022
ConversationCommits (9)ChecksFiles changed
Merged

Conversation

iritkatriel commented Dec 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

The functional except* changes were reviewed under PR30302 - I think they should be split out and not committed together with the POP_EXCEPT_AND_RERAISE change.

Otherwise, this just moves code from ceval.c to exceptions.c and sets me up to get a notification for PRs touching exceptions and tracebacks.

https://bugs.python.org/issue46221

https://bugs.python.org/issue46219

iritkatriel commented Dec 29, 2021
View reviewed changes
Comment thread Python/ceval.c
iritkatriel marked this pull request as draft December 30, 2021 11:55
iritkatriel changed the title bpo-45711: simplify except star implementation following exc_info changes. Move PREP_RERAISE_STAR helpers to exceptions.c bpo-46219, 46221: simplify except* implementation following exc_info changes. Move helpers to exceptions.c. Do not assume that exception groups are truthy. Jan 1, 2022
iritkatriel marked this pull request as ready for review January 1, 2022 14:37

iritkatriel commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

@erlend-aasland would you have time to review this? It’s mostly moving code from ceval.c to exceptions.c. Would be nice to get it into the next alpha release (due to be cut tomorrow) so it gets tested in close to final form.

erlend-aasland approved these changes Jan 2, 2022
View reviewed changes

erlend-aasland left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've looked at the changes in ceval and the compiler with good help from Irit. LGTM. Moving exception helpers to exception.c is a nice "cleanup".

iritkatriel commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

Thank you @erlend-aasland, @brandtbucher and @ericsnowcurrently for the reviews (on this an on PR30302 which contained the functional changes in this PR).

iritkatriel merged commit 65e7c1f into python:main Jan 2, 2022
iritkatriel deleted the simplify-except-star branch January 13, 2022 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes
gvanrossum Awaiting requested review from gvanrossum
markshannon Awaiting requested review from markshannon markshannon is a code owner
brandtbucher Awaiting requested review from brandtbucher
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL