bpo-46263: Do not ever expect "use_frozen_modules" to be -1. - #30438
Merged
ericsnowcurrently merged 2 commits intoJan 6, 2022
Merged
bpo-46263: Do not ever expect "use_frozen_modules" to be -1.#30438ericsnowcurrently merged 2 commits into
ericsnowcurrently merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 0513fe0 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check was added in gh-28940 (f1d3878 specifically) as a workaround in response to some buildbot failures. However, gh-29041 (for https://bugs.python.org/issue45582) made improvements to the "getpath" logic. Now a default "use_frozen_modules" is always set. So we can drop the workaround in the test.
This should resolve the buildbot failure on FreeBSD.
https://bugs.python.org/issue46263