bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494) - #30494
Merged
tiran merged 2 commits intoJan 9, 2022
Merged
bpo-40280: Disable epoll_create in Emscripten config.site (GH-30494)#30494tiran merged 2 commits into
tiran merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
With the fix in 994f90c building for Emscripten started failing with epoll link errors as can be seen here: https://github.com/ethanhs/python-wasm/runs/4745952720
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@sobolevn |
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 9, 2022
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yes, since this is new in 3.11 there should be no need for any backporting. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'd update the PR title to more accurately reflect the actual change, though. |
Sorry, something went wrong.
ngnpope
suggested changes
Jan 9, 2022
Comment thread
Tools/wasm/config.site-wasm32-emscripten
Outdated
Co-authored-by: nick.pope@infogrid.io
erlend-aasland
approved these changes
Jan 9, 2022
tiran
approved these changes
Jan 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the fix in 994f90c
building for Emscripten started failing with epoll link
errors as can be seen here:
https://github.com/ethanhs/python-wasm/runs/4745952720
I believe this shouldn't require a news entry.
https://bugs.python.org/issue40280