| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
I don't see how this qualifies for skip issue. Perhaps I am misreading the devguide, but to me this PR seems inappropriately labelled. If I am mistaken; sorry for the noise. |
Sorry, something went wrong.
|
@erlend-aasland Yes, I think you're right. I'll add an issue. |
Sorry, something went wrong.
| } | ||
|
|
||
| /* Create a new int object from a C long int */ | ||
|
|
There was a problem hiding this comment.
This is a minor consistency fix, following the Boy Scout Rule: the prevailing style in this file is to leave a blank line between the comment-description and the definition. But the change is not strictly necessary for this PR, and I can revert if reviewers prefer.
Sorry, something went wrong.
|
Thanks. Looks good on initial review. |
Sorry, something went wrong.
There was a problem hiding this comment.
Two changes that should silence compiler warnings.
Sorry, something went wrong.
|
Thanks, @markshannon. The compiler warnings have been silenced. |
Sorry, something went wrong.
|
Thanks |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR #27832 inadvertently introduced a couple of changes to PyLong_FromLong that didn't make a lot of sense: an (unsigned long) cast was replaced with (twodigits), and a digit count variable (counting number of PyLong digits in a C long) had its type needlessly changed from int to Py_ssize_t.
This PR:
https://bugs.python.org/issue46311