| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
FYI, we're "speed-testing" this PR over at https://github.com/hugovk/cpython/pulls |
Sorry, something went wrong.
|
@hugovk, based on the first cron run, I suggest the following changes:
Actually, I found the step with the "exempt rule" confusing to read compared to the step with the "only rule". It seems like the two rules are processed differently as well. For only-pr-labels, the action aborts almost immediately. For exempt-pr-labels it appears to abort much later in the process. |
Sorry, something went wrong.
Debug output from the PR which was caught by the exempt-rule [#17] Pull request #17 [#17] Found this pull request last updated at: 2022-01-09T16:25:57Z [#17] The option only-labels (https://github.com/actions/stale#only-labels) was not specified [#17] └── Continuing the process for this pull request [#17] Days before pull request stale: 1 [#17] The pull request is not closed nor locked. Trying to remove the close label... [#17] ├── The close-pr-label (https://github.com/actions/stale#close-pr-label) option was not set [#17] └── Skipping the removal of the close label [#17] This pull request hasn't a stale label [#17] Skipping this pull request because it has an exempt label [#18] Pull request #18 [#18] Found this pull request last updated at: 2022-01-09T16:25:48Z [#18] The option only-labels (https://github.com/actions/stale#only-labels) was specified to only process issues and pull requests with all those labels (1) [#18] └── Skipping this pull request because it doesn't have all the required labels I prefer the latter. |
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
@Mariatta, thank you for reviewing! I've added the do-not-merge label until we've tested this change properly on our forks (see the last TODO item). I'll remove that label if everything is all fine after we've finished testing. |
Sorry, something went wrong.
|
@hugovk, the logs look much better with the recent changes applied: https://github.com/hugovk/cpython/runs/4769591131?check_suite_focus=true |
Sorry, something went wrong.
|
I've tested this change on my fork, modified to mark a PR stale after 1 day, and close after 1 day (no CLA). I've verified, as expected, that PRs that are marked stale, and that received comments after being marked stale, will not be closed (cc. @ambv). For test PR 20, which received comments after being marked stale, the actions bot correctly removed the stale label on the following run. For test PR 21, which did not receive comments after being marked stale, the actions bot closed the PR on the following run. Here's the PRs:
(Removing the do-not-merge label, @Mariatta.) |
Sorry, something went wrong.
|
@ambv Are ok with this PR as it stands? |
Sorry, something went wrong.
|
@erlend-aasland yes, let's land it. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
See python/core-workflow#93