bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507) - #30507
Merged
tiran merged 1 commit intoJan 13, 2022
Merged
bpo-46315: Add ifdef HAVE_ feature checks for WASI compatibility (GH-30507)#30507tiran merged 1 commit into
tiran merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
erlend-aasland
approved these changes
Jan 9, 2022
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
* add check for HAVE_CLOCK * use HAVE_PTHREAD_H to guard include of pthread.h * guard getpid() with HAVE_GETPID * guard clock() with HAVE_CLOCK * add checks for HAVE_UMASK and HAVE_CHMOD * guard include of setjmp.h * use signal emulation on WASI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46315