FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46301: remove refleak from `Enum` tests by sobolevn · Pull Request #30510 · python/cpython · GitHub

/ cpython Public

bpo-46301: remove refleak from Enum tests - #30510

Merged
ethanfurman merged 2 commits into
python:mainfrom
sobolevn:issue-46301-refleak
Jan 10, 2022
ConversationCommits (2)ChecksFiles changed
Merged

bpo-46301: remove refleak from Enum tests#30510
ethanfurman merged 2 commits into
python:mainfrom
sobolevn:issue-46301-refleak

Conversation

sobolevn commented Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

It does not happen anymore, I've tested this locally using: PYTHONDUMPREFSFILE=ex.txt ./python.exe -m test -R : -v test_enum

Refs #30472

CC @ethanfurman and @pablogsal
And CC @corona10 as my mentor.

https://bugs.python.org/issue46301

sobolevn requested a review from ethanfurman as a code owner January 10, 2022 09:06
bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 10, 2022
sobolevn added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section skip news labels Jan 10, 2022

bedevere-bot commented Jan 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 9b858f5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 10, 2022

sobolevn commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

Looks like the CI failed for some unrelated reasons:

https://buildbot.python.org/all/#/builders/470/builds/379

I will try to apply test-with-buildbots again once all others will finish.

sobolevn commented Jan 10, 2022

Copy link
Copy Markdown
Member Author

Ok, buildbots take quite a long time to work (1h+). I hope that retriggering a single failing one is not so important. Other Refleak tests pass. So, I don't want to waste extra resources 🙂

sobolevn requested a review from pablogsal January 10, 2022 17:08
ethanfurman requested changes Jan 10, 2022
View reviewed changes

ethanfurman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like the solution.

While it pains me to say it, please fix the formatting.

Comment thread Lib/test/test_enum.py Outdated
# `_convert_` uses a module side effect that does this. See 30472
with support.swap_item(
sys.modules, MODULE, _ModuleWrapper(sys.modules[MODULE]),
):

ethanfurman Jan 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do not use Black formatting on enum code, please. Continuation lines should be eight space indents, and each closing ), ], and } should line up as if it were code and not syntax, with the final line (if it introduces a block) only indented the normal four spaces. In other words:

a_long_list_comprehension = [
        x
        for x in spam(eggs, ham)
        if x not in some_previous_group
        ]

and

with yada(
        arg1, arg2, something_else=None,
    ):
    # body of code

Comment thread Lib/test/test_enum.py
COMPLEX_A = 2j
COMPLEX_B = 3j

class _ModuleWrapper:

ethanfurman Jan 10, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like this. Please switch over the other _convert_ tests to use it, which will allow the removal of the setUp() methods in those tests.

bedevere-bot commented Jan 10, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

sobolevn commented Jan 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Done! Code formatting is very important I (as a maintainer of ~10 different linters) can totally relate 😊

Thanks for the review!

To make bot happy:

I have made the requested changes; please review again

ethanfurman commented Jan 10, 2022

Copy link
Copy Markdown
Member

I have made the requested changes; please review again

I think you forgot a period. ;-)

ethanfurman merged commit 582286d into python:main Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanfurman ethanfurman approved these changes
pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL