FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46345: add a test case for implicit `Optional` class attribute by sobolevn · Pull Request #30535 · python/cpython · GitHub

/ cpython Public

bpo-46345: add a test case for implicit Optional class attribute - #30535

Merged
gvanrossum merged 1 commit into
python:mainfrom
sobolevn:issue-46345
Jan 12, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-46345: add a test case for implicit Optional class attribute#30535
gvanrossum merged 1 commit into
python:mainfrom
sobolevn:issue-46345

Conversation

sobolevn commented Jan 11, 2022 •
edited by gvanrossum
Loading

Copy link
Copy Markdown
Member

sobolevn mentioned this pull request Jan 11, 2022
Merged
Fidget-Spinner approved these changes Jan 12, 2022
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Do you suggest we backport this?

sobolevn commented Jan 12, 2022

Copy link
Copy Markdown
Member Author

Thanks for the review! 👍

I think it is safe to backport to 3.10 and 3.9

gvanrossum commented Jan 12, 2022

Copy link
Copy Markdown
Member

Looks like the issue-number bot is stuck. Closing and reopening to restart it (sigh).

gvanrossum closed this Jan 12, 2022
gvanrossum reopened this Jan 12, 2022
gvanrossum merged commit 1de6015 into python:main Jan 12, 2022

miss-islington commented Jan 12, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot commented Jan 12, 2022

Copy link
Copy Markdown

GH-30567 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 12, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
bpo-46345: Add a test case for implicit Optional class attribute (p…
09cbc2e 
…ythonGH-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2022
bpo-46345: Add a test case for implicit Optional class attribute (p…
06e8491 
…ythonGH-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-bot commented Jan 12, 2022

Copy link
Copy Markdown

GH-30568 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jan 13, 2022
bpo-46345: Add a test case for implicit Optional class attribute (G…
a468866 
…H-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Jan 13, 2022
bpo-46345: Add a test case for implicit Optional class attribute (G…
d9101c4 
…H-30535)

(cherry picked from commit 1de6015)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

sobolevn commented Jan 13, 2022

Copy link
Copy Markdown
Member Author

Thanks everyone!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum gvanrossum approved these changes
Fidget-Spinner Fidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL