FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-40066: [Enum] update str() and format() output by ethanfurman · Pull Request #30582 · python/cpython · GitHub

/ cpython Public

bpo-40066: [Enum] update str() and format() output - #30582

Merged
ethanfurman merged 26 commits into
python:mainfrom
ethanfurman:40066-enum_output
Jan 16, 2022
ConversationCommits (26)ChecksFiles changed
Merged

bpo-40066: [Enum] update str() and format() output#30582
ethanfurman merged 26 commits into
python:mainfrom
ethanfurman:40066-enum_output

Conversation

ethanfurman commented Jan 13, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

AlexWaygood reopened this Jan 13, 2022

AlexWaygood commented Jan 13, 2022

Copy link
Copy Markdown
Member

Omg, did not mean to close that at all — sorry!!

sobolevn reviewed Jan 14, 2022
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for your work! Enums' text representation looks way better now.

Comment thread Doc/library/enum.rst Outdated
Comment thread Doc/library/enum.rst Outdated
Comment thread Doc/library/enum.rst Outdated
Comment thread Doc/library/enum.rst Outdated
Comment thread Lib/enum.py Outdated
Comment thread Lib/enum.py Outdated
Comment thread Lib/enum.py Outdated
Comment thread Lib/enum.py Outdated
Comment thread Lib/enum.py Outdated
ethanfurman merged commit acf7403 into python:main Jan 16, 2022

AlexWaygood commented Jan 16, 2022

Copy link
Copy Markdown
Member

This change appears to be causing CI to fail on docs for unrelated PRs ☹️ https://github.com/python/cpython/runs/4831439882?check_suite_focus=true

vstinner added a commit that referenced this pull request Jan 17, 2022
Revert "bpo-40066: [Enum] update str() and format() output (GH-30582)"
7d7be71 
This reverts commit acf7403.
vstinner mentioned this pull request Jan 17, 2022
Merged
vstinner added a commit that referenced this pull request Jan 17, 2022
Revert "bpo-40066: [Enum] update str() and format() output (GH-30582)" (
42a64c0 
GH-30632)

This reverts commit acf7403.
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 17, 2022
Revert "Revert "bpo-40066: [Enum] update str() and format() output (p…
39ecb6a 
…ythonGH-30582)" (pythonGH-30632)"

This reverts commit 42a64c0.
This was referenced May 23, 2022
Closed
Closed

AdamWill commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

I'm curious: why does this define a __init__ for Enum which does nothing at all (just pass)?

It causes pylint to start throwing warnings about subclasses of Enum which have their own __init__ not calling super's __init__, which Python's own docs and examples don't say they should, and which of course would be pointless since it does nothing. I'm sending a PR for pylint to not emit this warning for subclasses of Enum, but I don't understand why the do-nothing __init__ was added at all.

AdamWill mentioned this pull request Jul 11, 2022
Merged
DanielNoord mentioned this pull request Jul 14, 2022
Closed
mdboom mentioned this pull request Oct 13, 2022
Closed
ethanfurman deleted the 40066-enum_output branch November 23, 2022 23:50
gryznar reviewed Nov 25, 2022
View reviewed changes
Comment thread Lib/inspect.py
@@ -2567,30 +2567,28 @@ class _empty:


class _ParameterKind(enum.IntEnum):

gryznar Nov 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is that inheritting correct where the values are changed to str?

ethanfurman Nov 25, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gryznar Good question: only because the __new__ uses integers as the values, and the "value" on the assignment line is saved in the description attribute. Without the custom __new__ the enum creation would have failed, since strings are not integers.

gryznar reviewed Nov 25, 2022
View reviewed changes
Comment thread Lib/enum.py
if invalid_names:
raise ValueError('Invalid enum member name: {0}'.format(
','.join(invalid_names)))
raise ValueError('invalid enum member name(s) '.format(

gryznar Nov 25, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is removing "{0}" proper?

ethanfurman Nov 25, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gryznar Only because it was changed to %s later.

This was referenced Dec 18, 2024
Closed
Merged
hugovk mentioned this pull request Apr 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn left review comments
+1 more reviewer
gryznar gryznar left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL