GH-73991: Add pathlib.Path.move that can handle rename across FS - #30650
Closed
oz123 wants to merge 2 commits into
Closed
GH-73991: Add pathlib.Path.move that can handle rename across FS#30650oz123 wants to merge 2 commits into
oz123 wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
from
b885731 to
b3f4752
Compare
January 17, 2022 19:48
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
from
b3f4752 to
673f1c9
Compare
January 17, 2022 19:50
barneygale
reviewed
Jan 19, 2022
barneygale
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I'd prefer metadata=True over copy_function=shutil.copy2, and would like to request a third opinion :-)
Sorry, something went wrong.
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Doc/library/pathlib.rst
Outdated
Comment thread
Lib/pathlib.py
Outdated
Comment thread
Lib/test/test_pathlib.py
Outdated
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
2 times, most recently
from
9d35c9a to
b20e32f
Compare
January 24, 2022 22:35
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
from
b20e32f to
84157e1
Compare
February 4, 2022 13:09
barneygale
reviewed
Feb 5, 2022
Comment thread
Lib/pathlib.py
Outdated
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
from
bb1a964 to
29dfb12
Compare
February 5, 2022 23:21
With this change, ``pathlib.Path.move`` adds the ability to handle renaming across file system and also preserve metadata when renaming, since ``shutil.move`` using ``shutil.copy2`` is used under the hood.
oz123
force-pushed
the
bpo-46317-pathlib-move
branch
from
29dfb12 to
edce418
Compare
February 6, 2022 20:22
MaxwellDupre
approved these changes
Apr 13, 2022
MaxwellDupre
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Ran 462 tests in 3.520s
OK (skipped=137)
Added test passed. Looks ok.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'm going to close this PR because I've added a (different) implementation of move() in GH-122073. Thank you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for letting me know. I'm happy that the issue is finally resolved. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, Pathlib.move adds the ability
to handle renaming across file system and also preserve metadata
when renaming, since shutil.move using shutil.copy2 is used
under the hood.
https://bugs.python.org/issue46317
https://bugs.python.org/issue46317