FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46402: Promote SQLite URI tricks in `sqlite3` docs by erlend-aasland · Pull Request #30660 · python/cpython · GitHub

/ cpython Public

bpo-46402: Promote SQLite URI tricks in sqlite3 docs - #30660

Merged
ericvsmith merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-doc-uri-tricks
Jan 18, 2022
ConversationCommits (4)ChecksFiles changed
Merged

bpo-46402: Promote SQLite URI tricks in sqlite3 docs#30660
ericvsmith merged 4 commits into
python:mainfrom
erlend-aasland:sqlite-doc-uri-tricks

Conversation

erlend-aasland commented Jan 18, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 18, 2022
nedbat reviewed Jan 18, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated

nedbat commented Jan 18, 2022

Copy link
Copy Markdown
Member

This is great, thanks! I don't know if my vote counts for anything, but I approve. :)

Address review: Simplify URI explanation
ae5877e 
Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @nedbat :)

ericvsmith commented Jan 18, 2022

Copy link
Copy Markdown
Member

I think this looks great.

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

Thanks, Eric!

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

BTW, would you mind merging it? I don't have the commit bit.

ericvsmith commented Jan 18, 2022

Copy link
Copy Markdown
Member

Will do.

ericvsmith merged commit bdf2ab1 into python:main Jan 18, 2022

miss-islington commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-doc-uri-tricks branch January 18, 2022 12:37
bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 18, 2022

bedevere-bot commented Jan 18, 2022

Copy link
Copy Markdown

GH-30661 is a backport of this pull request to the 3.10 branch.

bedevere-bot commented Jan 18, 2022

Copy link
Copy Markdown

GH-30662 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
7b2d484 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2022
bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-30660)
4c14a65 
Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

erlend-aasland commented Jan 18, 2022

Copy link
Copy Markdown
Contributor Author

cc. @JulienPalard: I only need to update suspicious for the backports, right? (file: triggers the suspicious checks in 3.10 and 3.9).

erlend-aasland commented Jan 18, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

FYI: I'm closing the auto-backports and doing them myself in order to get the suspicious fixes into those.

ericvsmith pushed a commit that referenced this pull request Jan 18, 2022
[3.10] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (
01e6cbe 
GH-30671)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
ericvsmith pushed a commit that referenced this pull request Jan 18, 2022
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (GH-30660) (…
0ae2257 
…#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (GH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
nedbat mentioned this pull request May 16, 2022
Closed
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.9] bpo-46402: Promote SQLite URI tricks in sqlite3 docs (pythonGH-…
7d252fb 
…30660) (python#30672)

* bpo-46402: Promote SQLite URI tricks in `sqlite3` docs (pythonGH-30660)

Provide some examples of URI parameters in sqlite connect().

Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
(cherry picked from commit bdf2ab1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

* Update suspicious rules
erlend-aasland mentioned this pull request Jul 27, 2022
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nedbat nedbat left review comments
ericvsmith ericvsmith approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL