FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-12067: Add tests to test_compare by humbdrag · Pull Request #30667 · python/cpython · GitHub

/ cpython Public

bpo-12067: Add tests to test_compare - #30667

Closed
humbdrag wants to merge 2 commits into
python:mainfrom
humbdrag:bpo-12067
Closed

humbdrag wants to merge 2 commits into
python:mainfrom
humbdrag:bpo-12067

Conversation

humbdrag commented Jan 18, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor Author

This is not visible to users so I think "skip news" is applicable to this.

Copy link
Copy Markdown
Member

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

Copy link
Copy Markdown
Contributor Author

The changelog has a section Tests, so I see no reason to not mention extensive changes like this.

This seems nearly identical to #60625 and #30651 so the first should have been left open to get the revised CLA tag. But we can go with this one.

Thanks for the reply. Good point, added news file.

Copy link
Copy Markdown
Contributor Author

@terryjreedy Sorry for tagging but any further thoughts?

Copy link
Copy Markdown
Member

This appears more or less identical to the original PR, #3199, with original attributions and merge conflicts removed. Our workflow is to credit original authors and, when possible, to fix merge conflicts on the PR. I did so fairly easily, leaving this as redundant. If you have any comments or suggestions, please make them there.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL