bpo-46417: Add missing types of _PyTypes_InitTypes() - #30749
Merged
vstinner merged 1 commit intoJan 21, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This change doesn't fix the crash, Ubuntu failed on Azure Pipelines PR: test_mock_add_spec (unittest.test.testmock.testmock.MockTest) ... Fatal Python error: Segmentation fault Current thread 0x00007fda98424280 (most recent call first): File "/home/vsts/work/1/s/Lib/inspect.py", line 2179 in _signature_fromstr File "/home/vsts/work/1/s/Lib/inspect.py", line 2273 in _signature_from_builtin File "/home/vsts/work/1/s/Lib/inspect.py", line 2461 in _signature_from_callable File "/home/vsts/work/1/s/Lib/inspect.py", line 2465 in _signature_from_callable File "/home/vsts/work/1/s/Lib/inspect.py", line 2966 in from_callable File "/home/vsts/work/1/s/Lib/inspect.py", line 3218 in signature File "/home/vsts/work/1/s/Lib/unittest/mock.py", line 112 in _get_signature_object File "/home/vsts/work/1/s/Lib/unittest/mock.py", line 505 in _mock_add_spec File "/home/vsts/work/1/s/Lib/unittest/mock.py", line 487 in mock_add_spec File "/home/vsts/work/1/s/Lib/unittest/test/testmock/testmock.py", line 1781 in test_mock_add_spec ... I wrote a different change: PR #30750. |
Sorry, something went wrong.
Add types removed by mistake by the commit adding _PyTypes_FiniTypes(). Move also PyBool_Type at the end, since it depends on PyLong_Type. PyBytes_Type and PyUnicode_Type no longer depend explicitly on PyBaseObject_Type: it's the default of PyType_Ready().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add types removed by mistake by the commit adding
_PyTypes_FiniTypes().
Move also PyBool_Type at the end, since it depends on PyLong_Type.
PyBytes_Type and PyUnicode_Type no longer depend explicitly on
PyBaseObject_Type: it's the default of PyType_Ready().
https://bugs.python.org/issue46417