bpo-46417: Fix type recurse_down_subclasses() - #30775
Closed
vstinner wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Type recurse_down_subclasses() now calls _PyType_GetSubclasses() to iterate on a copy of subclasses, because its loop can modify subclasses: hold strong references to subclasses. * remove_subclass() now sets tp_subclasses to NULL if the dictionary becomes empty. * _PyType_GetSubclasses() no longer holds a reference to tp_subclasses: its loop cannot modify tp_subclasses. * remove_all_subclasses() no longer ignores objects which are not types: tp_bases must only contain types. Use _PyType_CAST() to ensure that the object is a type in debug mode. * mro_hierarchy() avoids _PyType_GetSubclasses() if tp_subclasses is NULL.
vstinner
marked this pull request as draft
January 22, 2022 02:25
Copy link
Copy Markdown
Member
Author
|
I wrote a real fix #30793 I will write a new cleanup PR on top on this fix PR. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type recurse_down_subclasses() now calls _PyType_GetSubclasses() to
iterate on a copy of subclasses, because its loop can modify
subclasses: hold strong references to subclasses.
becomes empty.
tp_subclasses: its loop cannot modify tp_subclasses.
types: tp_bases must only contain types. Use _PyType_CAST() to
ensure that the object is a type in debug mode.
NULL.
https://bugs.python.org/issue46417