FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46425: Partially revert GH-30682 by jaraco · Pull Request #30799 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-46425: Partially revert GH-30682 - #30799

Merged
jaraco merged 1 commit into
mainfrom
bpo-46425/restore-simple-importlib-tests
Jan 23, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-46425: Partially revert GH-30682#30799
jaraco merged 1 commit into
mainfrom
bpo-46425/restore-simple-importlib-tests

Conversation

jaraco commented Jan 22, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This reverts commit 57316c5 for files pertaining to importlib.metadata and importlib.resources (rationale).

https://bugs.python.org/issue46425

bpo-46425: Partially revert "bpo-46425: fix direct invocation of `tes…
1e0419f 
…t_importlib` (GH-30682)"

This reverts commit 57316c5 for files pertaining to importlib.metadata and importlib.resources.
bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 22, 2022
jaraco requested a review from sobolevn January 22, 2022 19:06
jaraco mentioned this pull request Jan 22, 2022
Merged

jaraco commented Jan 22, 2022

Copy link
Copy Markdown
Member Author

I confirmed by syncing this change into the backports that the backports no longer show a diff w.r.t the previous change.

sobolevn approved these changes Jan 22, 2022
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! The only difference between yours and #30800 is that I've left a comment on the very end of each file that is not suitable to be executed directly.

Sorry for a small breakage 🙂
TIL how backporting to https://github.com/python/importlib_metadata process looks like.

jaraco commented Jan 22, 2022

Copy link
Copy Markdown
Member Author

In #30800, we decided to proceed with option (b), so merging this now (once tests pass). Thanks!

sobolevn commented Jan 22, 2022

Copy link
Copy Markdown
Member

@jaraco tests most likely won't pass 🙂
See #30801

jaraco closed this Jan 23, 2022
jaraco reopened this Jan 23, 2022
jaraco merged commit d888ff5 into main Jan 23, 2022
jaraco deleted the bpo-46425/restore-simple-importlib-tests branch January 23, 2022 02:38
sobolevn mentioned this pull request Jan 23, 2022
Merged
sobolevn mentioned this pull request Apr 16, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sobolevn sobolevn approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL