bpo-46534: Implement PEP 673 Self in typing.py by Gobot1234 · Pull Request #30924 · python/cpython · GitHub

https://bugs.python.org/issue46534

Tests were copied from typing_extensions Co-authored-by: Pradeep Kumar Srinivasan <gohanpra@gmail.com>

Thanks a lot for your work! 👍

Did you mean to push some changes? Doesn't look like our comments were addressed.

Did you mean to push some changes? Doesn't look like our comments were addressed.

Sorry my bad.

The runtime behavior LGTM. If Jelle and Nikita (and anyone else interested) are happy with the docs I'll merge. Personally I think the docs are very clear too.

Thank you for implementing this James!

LGTM! Thanks again! 🎉

I personally still find the documentation a little sparse, and would love to see more of the stuff from PEP 673 included in the typing module documentation. (It was a really great PEP! Extremely clear and informative, really nicely written — kudos 😀)

Nonetheless, the documentation you've added here looks great, and more can always be added in future PRs.

Congrats on the PEP being accepted! I'm super excited to start using this feature :)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Should an entry be added to "What's New in Python 3.11"?

Should an entry be added to "What's New in Python 3.11"?

Yes.

Should that be done in this PR? I thought the what's new was collated manually later. I assume typing.reveal_type() and friends should also get what's new entries.

Should that be done in this PR? I thought the what's new was collated manually later. I assume typing.reveal_type() and friends should also get what's new entries.

What's New entries can be added at any time, and often are edited in a later stage. But there's absolutely no rule that says you can't add one at the same time you change the code! We've had a tradition of not requiring What's New for a few reasons: devs writing code aren't always good at writing docs, and vice versa; and sometimes What's New needs to be reorganized to make it more readable for users who want to quickly know what's changed. We especially want to avoid that What's New reads like a Changelog file -- we have the Misc/NEWS entries for that (those can still be edited but it rarely happens unless there are blatant errors, and the goal there is to be complete, just not as detailed as "git log" output).

So it's up to you.

Thanks Guido! For my function PRs, I'd rather add a single PR summarizing all of them in What's New once we have decided on each of the PRs. I'm also happy to add a What's New entry for PEP 673 in that case.

So I think this PR is ready to merge.

…nto pep-673-Self

@gvanrossum I think this can be merged now; Alex, Nikita, and I approved it. I'll work on What's New for typing in 3.11 once my other PRs are resolved.

Let's see how the tests fare (tip: when the tests aren't run because the PR submitter is new to the project, ask a core dev to run the tests).

Everything is green here now.

I wonder if instead of this complicated sentence we should just show the code (with a comment saying something like "don't do this, do the other thing").

Maybe also explain how this is similar and different than

class Foo:
    def return_self(self) -> "Foo":
        ...

…nto pep-673-Self

Thanks a lot for this @Gobot1234 and @pradeep90! And thanks Jelle for sponsoring.

Thank you to everyone that reviewed this.

Implementation of PEP 637 Self

40e7581

Tests were copied from typing_extensions Co-authored-by: Pradeep Kumar Srinivasan <gohanpra@gmail.com>

Gobot1234 requested review from Fidget-Spinner and gvanrossum as code owners January 26, 2022 18:05

the-knights-who-say-ni added the CLA signed label Jan 26, 2022

bedevere-bot added the awaiting review label Jan 26, 2022

📜🤖 Added by blurb_it.

72c1341

JelleZijlstra self-requested a review January 26, 2022 18:07

sobolevn reviewed Jan 26, 2022

View reviewed changes

Comment thread Doc/library/typing.rst Outdated

Comment thread Doc/library/typing.rst Outdated

Comment thread Doc/library/typing.rst Outdated

Comment thread Lib/test/test_typing.py

JelleZijlstra requested changes Jan 27, 2022

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2022-01-26-18-06-08.bpo-46534.vhzUM4.rst Outdated

Comment thread Doc/library/typing.rst Outdated

bedevere-bot added awaiting core review and removed awaiting review labels Jan 27, 2022

Respond to feedback

9afb1a5

Gobot1234 requested a review from JelleZijlstra January 27, 2022 20:11

Merge remote-tracking branch 'origin/pep-673-Self' into pep-673-Self

a1acb08

Fix typo

f4366e5

Fidget-Spinner reviewed Jan 30, 2022

View reviewed changes

sobolevn approved these changes Jan 30, 2022

View reviewed changes

AlexWaygood approved these changes Jan 30, 2022

View reviewed changes

JelleZijlstra reviewed Jan 30, 2022

View reviewed changes

Comment thread Doc/library/typing.rst Outdated

Gobot1234 and others added 3 commits January 30, 2022 19:29

Update Doc/library/typing.rst

a16c329

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Shorten line length

5613e8b

Merge branch 'main' into pep-673-Self

f8f6f76

Fix docs failing

4dbba7e

JelleZijlstra approved these changes Feb 2, 2022

View reviewed changes

kumaraditya303 reviewed Feb 2, 2022

View reviewed changes

Comment thread Misc/NEWS.d/next/Library/2022-01-26-18-06-08.bpo-46534.vhzUM4.rst Outdated

Gobot1234 and others added 3 commits February 2, 2022 13:13

Add an entry in whatschanged

5c3e674

Merge branch 'pep-673-Self' of https://github.com/Gobot1234/cpython i…

2ddcb78

…nto pep-673-Self

Merge branch 'main' into pep-673-Self

dba7c88

gvanrossum reviewed Feb 7, 2022

View reviewed changes

Gobot1234 and others added 3 commits February 7, 2022 12:36

Improve the documentation further

2b7e7cf

Merge branch 'pep-673-Self' of https://github.com/Gobot1234/cpython i…

0e068d7

…nto pep-673-Self

Update the news entry

2d23126

gvanrossum approved these changes Feb 7, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Feb 7, 2022

gvanrossum merged commit 7ba1cc8 into python:main Feb 7, 2022

bedevere-bot removed the awaiting merge label Feb 7, 2022

JelleZijlstra mentioned this pull request Feb 9, 2022

add new typing features python/typeshed#7169

Merged

Gobot1234 mannequin mentioned this pull request Apr 10, 2022

Implementing PEP 673 (Self type) #90692

Closed

coderabbitai Bot mentioned this pull request Apr 3, 2026

feat: add direct worker mode to co-locate Worker in TimingManager process ai-dynamo/aiperf#799

Closed

		This annotation is semantically equivalent to using a :class:`TypeVar` with ``bound=Foo`` as
		both the return annotation and the annotation for the ``self`` parameter.

bpo-46534: Implement PEP 673 Self in typing.py by Gobot1234 · Pull Request #30924 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-46534: Implement PEP 673 Self in typing.py - #30924

bpo-46534: Implement PEP 673 Self in typing.py#30924gvanrossum merged 15 commits intopython:mainpython/cpython:mainfrom Gobot1234:pep-673-SelfGobot1234/cpython:pep-673-SelfCopy head branch name to clipboard

Conversation

Gobot1234 commented Jan 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JelleZijlstra commented Jan 27, 2022

Uh oh!

Gobot1234 commented Jan 27, 2022

Uh oh!

Fidget-Spinner left a comment

Choose a reason for hiding this comment

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlexWaygood commented Jan 31, 2022

Uh oh!

gvanrossum commented Jan 31, 2022

Uh oh!

JelleZijlstra commented Feb 2, 2022

Uh oh!

gvanrossum commented Feb 2, 2022

Uh oh!

JelleZijlstra commented Feb 2, 2022

Uh oh!

Uh oh!

JelleZijlstra commented Feb 6, 2022

Uh oh!

gvanrossum commented Feb 6, 2022

Uh oh!

JelleZijlstra commented Feb 6, 2022

Uh oh!

gvanrossum Feb 6, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum commented Feb 7, 2022

Uh oh!

Gobot1234 commented Feb 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bpo-46534: Implement PEP 673 Self in typing.py#30924
gvanrossum merged 15 commits into
python:mainfrom
Gobot1234:pep-673-Self

Gobot1234 commented Jan 26, 2022 •
edited
Loading