bpo-46607: Add DeprecationWarning to LegacyInterpolation - #30927
Merged
gpshead merged 2 commits intoApr 5, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
0541fd9 to
80d4f4a
Compare
January 26, 2022 22:00
This comment has been minimized.
hugovk
marked this pull request as draft
January 27, 2022 09:20
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
80d4f4a to
2c616f3
Compare
February 2, 2022 07:06
This comment was marked as resolved.
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
2c616f3 to
850073b
Compare
February 2, 2022 18:45
hugovk
marked this pull request as ready for review
February 2, 2022 18:55
… in docs since 3.2
hugovk
force-pushed
the
issue45173-deprecate-LegacyInterpolation
branch
from
850073b to
2aa86b8
Compare
February 3, 2022 14:28
This comment was marked as resolved.
gvanrossum
approved these changes
Apr 2, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good. Let’s do this!
Sorry, something went wrong.
gpshead
approved these changes
Apr 5, 2022
Copy link
Copy Markdown
Member
|
@hugovk The PR introduces deprecation warnings in tests that need to be handled : PYTHONWARNINGS=always ./python -Wall -m test test_configparser 0:00:00 load avg: 2.29 Run tests sequentially 0:00:00 load avg: 2.29 [1/1] test_configparser /home/karthikeyan/stuff/python/cpython/Lib/test/test_configparser.py:1031: DeprecationWarning: LegacyInterpolation has been deprecated since Python 3.2 and will be removed from the configparser module in Python 3.13. Use BasicInterpolation or ExtendedInterpolation instead. interpolation = configparser.LegacyInterpolation() == Tests result: SUCCESS == 1 test OK. Total duration: 300 ms Tests result: SUCCESS |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@tirkarthi Thanks, will check it! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LegacyInterpolation has been deprecated in docs since its introduction in Python 3.2:
Let's add a DeprecationWarning for a couple of releases before removal.
https://bugs.python.org/issue46607