small simplification to eff_request_host in cookiejar.py - #31004
Conversation
Sorry, something went wrong.
`IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
Sorry, something went wrong.
|
Closing this stale PR because the CLA is still not signed. |
Sorry, something went wrong.
IPV4_RE includes a ., and the .find(".") == -1 included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern in syntax to make it clear what the check is doing here
(This change is trivial so I did not bother to open a BPO issue.)