FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) by erlend-aasland · Pull Request #31030 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) - #31030

Merged
JelleZijlstra merged 2 commits into
python:3.10from
erlend-aasland:backport-3eb3b4f-3.10
Feb 21, 2022
ConversationCommits (2)ChecksFiles changed
Merged

[3.10] bpo-43853: Expand test suite for SQLite UDF's (GH-27642)#31030
JelleZijlstra merged 2 commits into
python:3.10from
erlend-aasland:backport-3eb3b4f-3.10

Conversation

erlend-aasland commented Jan 30, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue43853

Erlend Egeberg Aasland added 2 commits January 26, 2022 22:23
[3.10] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642).
f0fd0bd 
(cherry picked from commit 3eb3b4f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Fix test_func_return_too_large_int
28de39f 
pythonGH-27613 (bpo 44839) was not backported, so exceptions differ between
main (3.11) and older versions.
bedevere-bot mentioned this pull request Jan 30, 2022
Merged

erlend-aasland commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

GH-27613 (bpo 44839) was not backported, so exceptions differ between main and older versions. See 28de39f.

JelleZijlstra commented Feb 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@gvanrossum I'm planning to merge this (a backport of #27642 which you previously merged after my review). The only non-test changes fix a missed error check for PyFloat_AsDouble, so this should be fine in the bugfix branches.

gvanrossum commented Feb 19, 2022

Copy link
Copy Markdown
Member

+1. If adding tests never caused us to fix any bugs we’d be doing it wrong. :-)

JelleZijlstra self-assigned this Feb 19, 2022
JelleZijlstra merged commit ba457fe into python:3.10 Feb 21, 2022

miss-islington commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented Feb 21, 2022

Copy link
Copy Markdown
Contributor

Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ba457fe6f8e50ad3ef3ceffb75dee96629a42ad7 3.9

erlend-aasland commented Feb 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks; I'll fix the 3.9 backport.

erlend-aasland deleted the backport-3eb3b4f-3.10 branch February 21, 2022 00:55
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Feb 25, 2022
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
b466671 
…ythonGH-31030)

(cherry picked from commit 3eb3b4f)

bedevere-bot commented Feb 25, 2022

Copy link
Copy Markdown

GH-31586 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit that referenced this pull request Mar 2, 2022
[3.9] bpo-43853: Expand test suite for SQLite UDF's (GH-27642) (GH-31030
3ea2a8f 
) (GH-31586)

(cherry picked from commit 3eb3b4f)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.9] bpo-43853: Expand test suite for SQLite UDF's (pythonGH-27642) (p…
3743da6 
…ythonGH-31030) (pythonGH-31586)

(cherry picked from commit 3eb3b4f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL