bpo-44977: Deprecate delegation of int to __trunc__ - #31031
Merged
serhiy-storchaka merged 2 commits intoFeb 3, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Calling int(a) when type(a) implements __trunc__ but not __int__ or __index__ now raises a DeprecationWarning.
serhiy-storchaka
approved these changes
Jan 31, 2022
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
kumaraditya303
requested changes
Jan 31, 2022
Comment thread
Doc/whatsnew/3.11.rst
| as deprecated, its docstring is now corrected). | ||
| (Contributed by Hugo van Kemenade in :issue:`45837`.) | ||
|
|
||
| * The delegation of :func:`int` to :meth:`__trunc__` is now deprecated. Calling |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| * The delegation of :func:`int` to :meth:`__trunc__` is now deprecated. Calling | |
| * The delegation of :class:`int` to :meth:`__trunc__` is now deprecated. Calling |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
int() is referred as a function here, not a class.
The current text is correct.
Sorry, something went wrong.
| @@ -0,0 +1,3 @@ | |||
| The delegation of :func:`int` to :meth:`__trunc__` is now deprecated. | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| The delegation of :func:`int` to :meth:`__trunc__` is now deprecated. | |
| The delegation of :class:`int` to :meth:`__trunc__` is now deprecated. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling int(a) when type(a) implements __trunc__ but not __int__ or __index__ now raises a DeprecationWarning.
https://bugs.python.org/issue44977