Repository navigation
bpo-46600: ./configure --with-pydebug uses -Og with clang - #31052
Merged
vstinner merged 2 commits intoFeb 1, 2022
Merged
vstinner merged 2 commits into
vstinner merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fix the test checking if the C compiler supports -Og option in the ./configure script to also use -Og on clang which supports it.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
erlend-aasland
approved these changes
Feb 1, 2022
Copy link
Copy Markdown
Member
Author
|
@erlend-aasland: Done, I added a second commit to use _SAVE_VAR/_RESTORE_VAR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This PR seems to have broken a bunch of buildbots. If no fix is provided in 24 hours, we will need to revert :( |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sure, the law is the law. I proposed a fix: GH-31058. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the test checking if the C compiler supports -Og option in the
./configure script to also use -Og on clang which supports it.
https://bugs.python.org/issue46600