FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45975: Use walrus operator for while loops in IDLE by nickdrozd · Pull Request #31083 · python/cpython · GitHub

/ cpython Public

bpo-45975: Use walrus operator for while loops in IDLE - #31083

Merged
terryjreedy merged 1 commit into
python:mainfrom
nickdrozd:idle-walrus
Feb 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-45975: Use walrus operator for while loops in IDLE#31083
terryjreedy merged 1 commit into
python:mainfrom
nickdrozd:idle-walrus

Conversation

nickdrozd commented Feb 2, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

By request of @terryjreedy, these are just the IDLE changes from #29347.

https://bugs.python.org/issue45975

nickdrozd mentioned this pull request Feb 2, 2022
Merged
zware added the skip news label Feb 2, 2022
terryjreedy merged commit 51a95be into python:main Feb 3, 2022

miss-islington commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2022
bpo-45975: Use walrus operator for some idlelib while loops (pythonGH…
f8e1c13 
…-31083)

(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>

miss-islington commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Sorry, @nickdrozd and @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 3, 2022

bedevere-bot commented Feb 3, 2022

Copy link
Copy Markdown

GH-31091 is a backport of this pull request to the 3.10 branch.

miss-islington commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @nickdrozd for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Sorry @nickdrozd and @terryjreedy, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 51a95be1d035a717ab29e98056b8831a98e61125 3.9

miss-islington added a commit that referenced this pull request Feb 3, 2022
bpo-45975: Use walrus operator for some idlelib while loops (GH-31083)
2ddc278 
(cherry picked from commit 51a95be)

Co-authored-by: Nick Drozd <nicholasdrozd@gmail.com>

terryjreedy commented Feb 3, 2022

Copy link
Copy Markdown
Member

I reviewed the changes, ran test_idle, and manually exercised features that should run the affected code.
The merge issue is that the sideport changes are to sections adding in 3.10.

terryjreedy added a commit that referenced this pull request Feb 3, 2022
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (GH…
fafd2da 
…-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
nickdrozd deleted the idle-walrus branch February 3, 2022 03:58

nickdrozd commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, @terryjreedy!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.9] bpo-45975: Use walrus operator for some idlelib while loops (py…
ab38b43 
…thonGH-31083)

co-authored by Nick Drozd
cherrypicked from 51a95be
nickdrozd mannequin mentioned this pull request Dec 6, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL