FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46659: Deprecate locale.getdefaultlocale() by vstinner · Pull Request #31206 · python/cpython · GitHub

/ cpython Public

bpo-46659: Deprecate locale.getdefaultlocale() - #31206

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:deprecate_getdefaultlocale
Feb 22, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-46659: Deprecate locale.getdefaultlocale()#31206
vstinner merged 1 commit into
python:mainfrom
vstinner:deprecate_getdefaultlocale

Conversation

vstinner commented Feb 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The locale.getdefaultlocale() function is deprecated and will be removed in
Python 3.13. Use locale.setlocale(),
locale.getpreferredencoding(False) and locale.getlocale() functions
instead.

https://bugs.python.org/issue46659

vstinner changed the title bpo-43557: Deprecate locale.getdefaultlocale() bpo-46659: Deprecate locale.getdefaultlocale() Feb 8, 2022

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

cc @malemburg

bpo-46659: Deprecate locale.getdefaultlocale()
abe8f1e 
The locale.getdefaultlocale() function is deprecated and will be
removed in Python 3.13. Use locale.setlocale(),
locale.getpreferredencoding(False) and locale.getlocale() functions
instead.

vstinner commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka @methane

methane commented Feb 9, 2022

Copy link
Copy Markdown
Member

Locale is too difficult to me, so I can not say LGTM.
At least, I feel it is very tempting API that can be used to get preferred language without calling setlocale()...

vstinner commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

At least, I feel it is very tempting API that can be used to get preferred language without calling setlocale()...

The function is convenient until you fall into a case where it doesn't work as expected. It's similar to mixing Python 2 str and unicode types. It works in most cases, until someone enters a name with a single non-ASCII character, and then suddently everything fall apart.

vstinner merged commit b899126 into python:main Feb 22, 2022
vstinner deleted the deprecate_getdefaultlocale branch February 22, 2022 21:06
vstinner mentioned this pull request Apr 10, 2022
Closed
vstinner mentioned this pull request Dec 11, 2022
Closed
2trvl mentioned this pull request Mar 7, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL