FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46685: improve test coverage of `Self` and `Never` in `typing` by sobolevn · Pull Request #31222 · python/cpython · GitHub

/ cpython Public

bpo-46685: improve test coverage of Self and Never in typing - #31222

Merged
JelleZijlstra merged 5 commits into
python:mainfrom
sobolevn:issue-46685
Feb 19, 2022
ConversationCommits (5)ChecksFiles changed
Merged

bpo-46685: improve test coverage of Self and Never in typing#31222
JelleZijlstra merged 5 commits into
python:mainfrom
sobolevn:issue-46685

Conversation

sobolevn commented Feb 8, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Feb 8, 2022
JelleZijlstra self-requested a review February 8, 2022 20:05

JelleZijlstra commented Feb 8, 2022

Copy link
Copy Markdown
Member

While you're fixing tests, would you mind renaming the AllTests class to DunderAllTests? Every time I see it that name confuses me into thinking it has all of the tests.

JelleZijlstra commented Feb 8, 2022

Copy link
Copy Markdown
Member

On second thought, maybe not: if we make that change we should do it in the bugfix branches too, but the rest of this PR is only applicable to 3.11.

sobolevn commented Feb 8, 2022

Copy link
Copy Markdown
Member Author

@JelleZijlstra by the way, while working on __all__ in typeshed, I've noticed that many modules with __all__ don't have check__all__ test.

I can send a PR with it, if others think it is a good idea.

I personally think, that it is! Because it can help us catching problems with public / not-exported names in the future.

JelleZijlstra reviewed Feb 8, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
sobolevn mentioned this pull request Feb 8, 2022
Merged
GBeauregard reviewed Feb 8, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Outdated
JelleZijlstra added a commit to JelleZijlstra/typing that referenced this pull request Feb 9, 2022
Add Never and assert_never
2faa2a8 
Backport of python/cpython#30842, with additional tests from @sobolevn's python/cpython#31222.
JelleZijlstra mentioned this pull request Feb 9, 2022
Merged
GBeauregard approved these changes Feb 9, 2022
View reviewed changes

GBeauregard left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks.

There are other typeforms where the _type_check path is untested too, and not just special forms. For the most part you can test all of them with stringification+get_type_hints. I'd been thinking lately about the best idea for fixing this coverage gap but haven't gotten to it.

The only one I'm currently aware of that fails such a check are ParamSpec's P.args and P.kwargs. I have a bpo open for this from the Annotated side of the bug, but it's the same problem. I will fix it when that stuff gets hashed out. But, I fixed 3 or so other bugs that would have been caught by these types of tests over the past 2 weeks, so there may be more 👀

JelleZijlstra added a commit to python/typing that referenced this pull request Feb 11, 2022
Add Never and assert_never (#1060)
a53957c 
Backport of python/cpython#30842, with additional tests from @sobolevn's python/cpython#31222.
JelleZijlstra approved these changes Feb 17, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I am planning to merge in a few days (cc @gvanrossum).

JelleZijlstra self-assigned this Feb 17, 2022
gvanrossum approved these changes Feb 17, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1

JelleZijlstra merged commit 32e3e0b into python:main Feb 19, 2022
JelleZijlstra added a commit to python/typing_extensions that referenced this pull request May 19, 2022
Add Never and assert_never (#1060)
5054b4b 
Backport of python/cpython#30842, with additional tests from @sobolevn's python/cpython#31222.
JelleZijlstra added a commit to python/typing_extensions that referenced this pull request May 19, 2022
Add Never and assert_never (#1060)
039b433 
Backport of python/cpython#30842, with additional tests from @sobolevn's python/cpython#31222.
JelleZijlstra added a commit to python/typing_extensions that referenced this pull request May 19, 2022
Add Never and assert_never (#1060)
ba258bb 
Backport of python/cpython#30842, with additional tests from @sobolevn's python/cpython#31222.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum gvanrossum approved these changes
Fidget-Spinner Awaiting requested review from Fidget-Spinner
+1 more reviewer
GBeauregard GBeauregard approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

JelleZijlstra

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL