bpo-46066: catch DeprecationWarning - #31428
Merged
JelleZijlstra merged 2 commits intoFeb 20, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
JelleZijlstra
requested review from
Fidget-Spinner and
gvanrossum
as code owners
February 19, 2022 06:02
sobolevn
reviewed
Feb 19, 2022
Comment thread
Lib/test/test_typing.py
Outdated
97littleleaf11
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Oops, sorry that I missed the warnings. Thanks @tirkarthi for pointing out!
Sorry, something went wrong.
Comment thread
Lib/test/test_typing.py
Outdated
JelleZijlstra
commented
Feb 19, 2022
Comment thread
Lib/test/test_typing.py
Outdated
sobolevn
approved these changes
Feb 19, 2022
sobolevn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@gvanrossum Planning to merge this simple PR (fixes an oversight in the TD kwargs deprecation change; approved by Nikita). |
Sorry, something went wrong.
gvanrossum
approved these changes
Feb 19, 2022
gvanrossum
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I’d rephrase the commit message using “Check deprecation warning”.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46066