FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46771: Implement task cancel requests by Tinche · Pull Request #31508 · python/cpython · GitHub

/ cpython Public

bpo-46771: Implement task cancel requests - #31508

Closed
Tinche wants to merge 1 commit into
python:issue-46771from
asvetlov:issue-46771-cancel-requests
ConversationCommits (1)ChecksFiles changed
Closed

bpo-46771: Implement task cancel requests#31508
Tinche wants to merge 1 commit into
python:issue-46771from
asvetlov:issue-46771-cancel-requests

Conversation

Tinche commented Feb 22, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Tinche requested review from 1st1 and asvetlov as code owners February 22, 2022 19:11
Tinche mentioned this pull request Feb 22, 2022
Merged

asvetlov commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Not sure if python:issue-46771 is the best base branch.
Maybe this PR should be made against main?

Tinche commented Feb 22, 2022

Copy link
Copy Markdown
Contributor Author

@gvanrossum said he would like this merged into issue-46771 first, and then merge that into main, so I'm following this plan.

gvanrossum commented Feb 22, 2022

Copy link
Copy Markdown
Member

@gvanrossum said he would like this merged into issue-46771 first, and then merge that into main, so I'm following this plan.

I think you misunderstood me. I meant for this to be a PR against main, which would be merged into main before merging the timeout class (presumably the branch with the timeout class would have to merge main in first, after the cancel changes were merged into main).

Tinche closed this Feb 22, 2022
asvetlov deleted the issue-46771-cancel-requests branch February 22, 2022 23:50
gvanrossum mentioned this pull request May 24, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 Awaiting requested review from 1st1
asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL