bpo-45885: Don't un-adapt COMPARE_OP when collecting stats - #31516
Merged
markshannon merged 3 commits intoFeb 23, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
sweeneyde
approved these changes
Feb 23, 2022
sweeneyde
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice -- this puts this failure kind on equal footing with the other failure kinds so the stats are more honest.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
👍 |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current stats obscure the fact that "not followed by conditional jump" accounts for a significant portion of possible COMPARE_OP hits. This patch takes the same approach that BINARY_OP uses of only un-adapting the instruction when stats aren't being collected.
New stats:
COMPARE_OP
specialization stats for COMPARE_OP familySpecialization attempts
https://bugs.python.org/issue45885