FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-46752: Taskgroup tweaks by Tinche · Pull Request #31559 · python/cpython · GitHub

/ cpython Public

bpo-46752: Taskgroup tweaks - #31559

Merged
gvanrossum merged 1 commit into
python:mainfrom
Tinche:bpo-46752-cancel
Feb 26, 2022
ConversationCommits (1)ChecksFiles changed
Merged

bpo-46752: Taskgroup tweaks#31559
gvanrossum merged 1 commit into
python:mainfrom
Tinche:bpo-46752-cancel

Conversation

Tinche commented Feb 25, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Here are some taskgroup tweaks, mostly from the cancellation changes and @gvanrossum 's comments in #31513 (comment).

  • check the return value of .uncancel() to decide whether to propagate the CancelledError
  • propagate the CancelledError exception properly in some cases
  • _abort() only once, instead of potentially multiple times (unsure if it could've happened in reality)
  • renamed a couple of tests that I worked on to be a little more descriptive

https://bugs.python.org/issue46752

Tinche requested review from 1st1 and asvetlov as code owners February 25, 2022 01:17
gvanrossum approved these changes Feb 25, 2022
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Unless @asvetlov or @1st1 peeps I'll merge this in a day or so.

kumaraditya303 approved these changes Feb 25, 2022
View reviewed changes

kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gvanrossum merged commit edbee56 into python:main Feb 26, 2022
asvetlov pushed a commit that referenced this pull request Feb 26, 2022
Taskgroup tweaks (GH-31559)
10f07fb 
Now uses .cancel()/.uncancel(), for even fewer broken edge cases.
gvanrossum mentioned this pull request Apr 27, 2022
Closed
gvanrossum mentioned this pull request Aug 7, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
kumaraditya303 kumaraditya303 approved these changes
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL