FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove new line in pickle error message by harshil21 · Pull Request #31782 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Remove new line in pickle error message - #31782

Merged
iritkatriel merged 6 commits into
python:mainfrom
harshil21:patch-1
Nov 7, 2022
ConversationCommits (6)ChecksFiles changed
Merged

Remove new line in pickle error message#31782
iritkatriel merged 6 commits into
python:mainfrom
harshil21:patch-1

Conversation

harshil21 commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Removes the new line in the error message. Encountered this while testing something and found it a little weird that there would be a new line character when the error message is short anyway.

harshil21 commented Jun 5, 2022

Copy link
Copy Markdown
Contributor Author

Hi, is this change going to be implemented? If not, I'll just close.

bedevere-bot commented Sep 6, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes

nanjekyejoannah left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I doubt we need a news entry for this. Also docs seem to be failing.

harshil21 commented Oct 8, 2022

Copy link
Copy Markdown
Contributor Author

I think it's failing because there isn't an issue for this PR. Maybe I should delete the NEWS.d entry then?

nanjekyejoannah reviewed Oct 11, 2022
View reviewed changes

nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, remove the news entry

bedevere-bot commented Oct 11, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

iritkatriel commented Nov 6, 2022

Copy link
Copy Markdown
Member

@serhiy-storchaka - as someone who's been looking at pickle issue recently, do you see any problem with this change? Does it need a news entry?

serhiy-storchaka approved these changes Nov 6, 2022
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is a very old code. It was added in fdde96c.

I do not know reasons of adding a newline at the first place, but the change LGTM.

iritkatriel merged commit cfec5b1 into python:main Nov 7, 2022
harshil21 deleted the patch-1 branch November 7, 2022 16:51
harshil21 mentioned this pull request Jun 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nanjekyejoannah nanjekyejoannah approved these changes
serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL