FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45138: Fix regression in GH-28240 by erlend-aasland · Pull Request #31783 · python/cpython · GitHub

/ cpython Public

bpo-45138: Fix regression in GH-28240 - #31783

Closed
erlend-aasland wants to merge 5 commits into
python:mainfrom
erlend-aasland:fix-trace
ConversationCommits (5)ChecksFiles changed
Closed

bpo-45138: Fix regression in GH-28240#31783
erlend-aasland wants to merge 5 commits into
python:mainfrom
erlend-aasland:fix-trace

Conversation

erlend-aasland commented Mar 9, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

cc. @JelleZijlstra @pablogsal

erlend-aasland reopened this Mar 9, 2022
JelleZijlstra approved these changes Mar 9, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good, I can merge it once we're both happy with it (cc @gvanrossum).

We should also test with buildbots though.

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

We should also test with buildbots though.

I tried adding the buildbot label via the GH app, but for some reason it does not work. Feel free to send it to the bots now.

JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022

bedevere-bot commented Mar 9, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0ab2575 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

s390x SLES PR failed. This PR needs more work.

gvanrossum commented Mar 9, 2022

Copy link
Copy Markdown
Member

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.

Yep, there are some red ones left; I think we should revert now, especially given Łukasz' recent plea about keeping the bots green. I'll close this and submit a new PR in a couple of days.

erlend-aasland deleted the fix-trace branch March 9, 2022 17:10

JelleZijlstra commented Mar 9, 2022

Copy link
Copy Markdown
Member

Thanks, yes I was also going to suggest reverting.

erlend-aasland mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL