FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-43224: Implement substitution of unpacked TypeVarTuple in C by serhiy-storchaka · Pull Request #31828 · python/cpython · GitHub

/ cpython Public

bpo-43224: Implement substitution of unpacked TypeVarTuple in C - #31828

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:typevartuple-subst-c
Apr 30, 2022
ConversationCommits (5)ChecksFiles changed
Merged

bpo-43224: Implement substitution of unpacked TypeVarTuple in C#31828
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:typevartuple-subst-c

Conversation

serhiy-storchaka commented Mar 11, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added the type-feature A feature request or enhancement label Mar 11, 2022

JelleZijlstra commented Mar 11, 2022

Copy link
Copy Markdown
Member

Thanks for working on this! Please don't merge this without approval from the PEP 646 authors or the typing experts; I'm not confident we'll get all the edge cases right. I'd have liked a chance to review #31800 in more detail too.

JelleZijlstra requested changes Mar 12, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I found a crash; see comment.

In general I'm worried that this approach will be too difficult to get right in all cases. I'd prefer the approach in #31804, which I suggested in #31021 (review).

Comment thread Objects/genericaliasobject.c Outdated
if (varparam < nparams) {
if (nitems < nparams - 1) {
return PyErr_Format(PyExc_TypeError,
"!Too few arguments for %R",

JelleZijlstra Mar 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
"!Too few arguments for %R",
"Too few arguments for %R",

Or does ! do something here?

serhiy-storchaka Mar 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was temporary, for debugging.

Comment thread Lib/test/test_typing.py
class G(Generic[Unpack[Ts]]): pass

for A in G, Tuple:
for A in G, Tuple, tuple:

JelleZijlstra Mar 12, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There need to be more tests for cases where we substitute an unpacked tuple into the TypeVarTuple. I found a crash on your branch:

 % ./python.exe 
Python 3.11.0a6+ (heads/serhiy-storchaka-typevartuple-subst-c:a35af462a3, Mar 11 2022, 19:02:45) [Clang 13.0.0 (clang-1300.0.29.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information
>>> from typing import Unpack, TypeVarTuple
>>> Ts = TypeVarTuple("Ts")
>>> t = tuple[Ts]
>>> t[int, Unpack[tuple[int, str]], str]
Assertion failed: (iparam != varparam), function _Py_subs_parameters, file genericaliasobject.c, line 382.
zsh: abort      ./python.exe

serhiy-storchaka Mar 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch. Is not tuple[Ts] illegal?

I have added a runtime error for this case. It is consistent for Tuple, tuple and user generics.

bedevere-bot commented Mar 12, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

And if you don't make the requested changes, you will be poked with soft cushions!

serhiy-storchaka commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.

bedevere-bot commented Mar 12, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@JelleZijlstra: please review the changes made to this pull request.

mrahtz commented Mar 12, 2022

Copy link
Copy Markdown
Contributor

Wow, thanks for implementing this - it hadn't even occurred to me this would be needed!

I also feel uneasy, though - as I mentioned in #31800 we'd decided against implementing it this way. I think we should pause work on this until we've decided on exactly which approach we're proceeding with.

mrahtz commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

Based on your note in #31800, I'm guessing you're going to proceed with this anyway. In that case, I think it would be worth adding some tests to this PR along the lines of b9b1c80#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dL794.

serhiy-storchaka commented Mar 13, 2022

Copy link
Copy Markdown
Member Author

I do not understand what tests are in question. The change you referred removes tests, not adds new tests.

mrahtz commented Mar 13, 2022

Copy link
Copy Markdown
Contributor

Right - I'm proposing adding them back, with the changes necessary to also test the code in this PR.

This was referenced Mar 13, 2022
Closed
Merged
serhiy-storchaka mentioned this pull request Mar 17, 2022
Merged
mrahtz mannequin mentioned this pull request Apr 11, 2022
Closed
mrahtz mentioned this pull request Apr 29, 2022
Closed
JelleZijlstra and others added 2 commits April 29, 2022 14:04
Merge branch 'main' into typevartuple-subst-c
985f50f
Update unpack test cases
0b9a4d3 
(Code by Matthew Rahtz)

Co-authored-by: Matthew Rahtz <mrahtz@gmail.com>
JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022

bedevere-bot commented Apr 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0b9a4d3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 29, 2022
serhiy-storchaka merged commit e8c2f72 into python:main Apr 30, 2022
serhiy-storchaka deleted the typevartuple-subst-c branch April 30, 2022 05:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

No one assigned

Labels

skip news topic-typing type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL