Refactor asyncio.wait_for() - #31847
Closed
asvetlov wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
graingert
reviewed
Jul 20, 2022
Comment thread
Lib/asyncio/tasks.py
|
|
||
| fut = ensure_future(fut, loop=loop) | ||
| fut.add_done_callback(cb) | ||
| async def inner(): |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@asvetlov I've been having a go at this branch in bf594bd
you need to special case None in asyncio.wait_for(
Suggested change
| async def inner(): | |
| if timeout is None: | |
| return await fut | |
| async def inner(): |
and then special case 0 in timeouts.timeout see https://gist.github.com/graingert/ea2546b23b32be5a4493a9a115db2eff#file-timeout_bug-py-L6
Sorry, something went wrong.
graingert
reviewed
Jul 21, 2022
Comment thread
Lib/asyncio/tasks.py
| raise exceptions.TimeoutError() from exc | ||
| finally: | ||
| timeout_handle.cancel() | ||
| return await create_task(inner()) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I don't think this extra create_task is worth it, the tests it passes are equivalent to:
async def wait_for(fut, delay):
if delay is None:
return await fut
if delay <= 0:
if asyncio.iscoroutine(fut):
fut.close()
raise TimeoutError
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think it would be better to skip this create_task and delete the tests that fail
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.