FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-45150: draft implementation only for sha224,sha256 by SonOfLilit · Pull Request #31928 · python/cpython · GitHub

/ cpython Public

bpo-45150: draft implementation only for sha224,sha256 - #31928

Closed
SonOfLilit wants to merge 2 commits into
python:mainfrom
SonOfLilit:main
ConversationCommits (2)ChecksFiles changed
Closed

bpo-45150: draft implementation only for sha224,sha256#31928
SonOfLilit wants to merge 2 commits into
python:mainfrom
SonOfLilit:main

Conversation

SonOfLilit commented Mar 16, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

This is only a draft, after review I will write similar code for all other internal hash implementations, as well as for OpenSSL-based implementations.

https://bugs.python.org/issue45150

SonOfLilit requested a review from tiran as a code owner March 16, 2022 02:11

the-knights-who-say-ni commented Mar 16, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@SonOfLilit

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

gpshead marked this pull request as draft March 16, 2022 21:07

gpshead commented Mar 16, 2022

Copy link
Copy Markdown
Member

I do not think we should be writing C code for the initial implementation of this feature. I like where #31930 is headed.

tarekziade mannequin mentioned this pull request Aug 13, 2022
Closed

arhadthedev commented Feb 16, 2023

Copy link
Copy Markdown
Member

Superseded by gh-31930.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tiran Awaiting requested review from tiran
gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner
picnixz Awaiting requested review from picnixz picnixz will be requested when the pull request is marked ready for review picnixz is a code owner

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL