bpo-34861: Make cumtime the default sorting key for cProfile - #31929
Merged
pablogsal merged 1 commit intoMar 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-authored-by: =?UTF-8?q?Anders=20Hovm=C3=B6ller?= <anders.hovmoller@trioptima.com>
MaxwellDupre
approved these changes
Mar 26, 2022
MaxwellDupre
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks ok.
Sorry, something went wrong.
pablogsal
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This does not fully resolve bpo-34861, but only tackles one of the two issues identified.
This is a resubmit of #9655 and some of the changes that were discussed there.
@pablogsal I'm tagging you since you basically asked for the PR to be split and said that this change looked good. Sorry if the ping is uncalled for.
I have also updated the documentation to better reflect what a new call to cProfile.run('re.compile("foo|bar")') would look like. This also shows that we no longer sort on standard name.
https://bugs.python.org/issue34861