gh-91181: drop support for bytes on sys.path - #31934
Merged
brettcannon merged 11 commits intoJul 17, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
eryksun
reviewed
Mar 16, 2022
Comment thread
Doc/library/sys.rst
Outdated
graingert
force-pushed
the
drop-support-for-bytes-on-sys-path
branch
from
9106835 to
6b8403e
Compare
March 16, 2022 18:14
Co-authored-by: Eryk Sun <eryksun@gmail.com>
graingert
force-pushed
the
drop-support-for-bytes-on-sys-path
branch
from
6b8403e to
8a76d18
Compare
March 16, 2022 19:49
graingert
marked this pull request as ready for review
March 16, 2022 20:44
graingert
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
March 16, 2022 20:44
MaxwellDupre
approved these changes
Mar 26, 2022
MaxwellDupre
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks ok.
Sorry, something went wrong.
jaraco
approved these changes
Jun 26, 2022
jaraco
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Not an authoritative approval, but this approach is my preference.
Sorry, something went wrong.
This comment was marked as outdated.
brettcannon
approved these changes
Jul 12, 2022
brettcannon
reviewed
Jul 17, 2022
Comment thread
Misc/NEWS.d/next/Library/2022-03-16-14-24-14.bpo-47025.qtT3CE.rst
Outdated
brettcannon
approved these changes
Jul 17, 2022
Copy link
Copy Markdown
Contributor
|
Thanks @graingert for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 17, 2022
Support for bytes broke sometime between Python 3.2 and 3.6 and has been broken ever since. Trying to bring back supports is surprisingly difficult in the face of -b and checking for keys in sys.path_importer_cache. Since the support was broken for so long, trying to overcome the difficulty of bringing back the support has been deemed not worth it. Co-authored-by: Eryk Sun <eryksun@gmail.com> Co-authored-by: Brett Cannon <brett@python.org> (cherry picked from commit 6da988a) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Copy link
Copy Markdown
|
GH-94914 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
miss-islington
added a commit
that referenced
this pull request
Jul 17, 2022
Support for bytes broke sometime between Python 3.2 and 3.6 and has been broken ever since. Trying to bring back supports is surprisingly difficult in the face of -b and checking for keys in sys.path_importer_cache. Since the support was broken for so long, trying to overcome the difficulty of bringing back the support has been deemed not worth it. Co-authored-by: Eryk Sun <eryksun@gmail.com> Co-authored-by: Brett Cannon <brett@python.org> (cherry picked from commit 6da988a) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for bytes broke sometime between Python 3.2 and 3.6 and has been broken ever since. Trying to bring back supports is surprisingly difficult in the face of -b and checking for keys in sys.path_importer_cache. Since the support was broken for so long, trying to overcome the difficulty of bringing back the support has been deemed not worth it.