[3.5] bpo-31095: fix potential crash during GC - #3196
Merged
larryhastings merged 3 commits intoSep 26, 2017
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
(cherry picked from commit a6296d3)
Copy link
Copy Markdown
Contributor
|
Hi, Steve, this is failing on link, can you look in to it? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Link error message in AppVeyor: [00:03:36] Finished generating code [00:03:37] Creating library C:\projects\cpython\PCBuild\win32\_elementtree.lib and object C:\projects\cpython\PCBuild\win32\_elementtree.exp [00:03:37] xmlparse.obj : error LNK2001: unresolved external symbol __Expat_LoadLibrary [C:\projects\cpython\PCbuild\_elementtree.vcxproj] [00:03:37] C:\projects\cpython\PCBuild\win32\_elementtree.pyd : fatal error LNK1120: 1 unresolved externals [C:\projects\cpython\PCbuild\_elementtree.vcxproj] |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like the pyexpat.vcxproj file was never updated with the last update, and whoever merged that updated didn't run appveyor (or they ignored the failure). I'll send a PR to update the file. Looks like 3.6 got the change okay, so guessing it's just 3.5. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit a6296d3)
https://bugs.python.org/issue31095