FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891) by hugovk · Pull Request #31998 · python/cpython · GitHub

/ cpython Public

[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891) - #31998

Merged
brettcannon merged 1 commit into
python:3.9from
hugovk:backport-7747384-3.9
Mar 22, 2022
ConversationCommits (1)ChecksFiles changed
Merged

[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891)#31998
brettcannon merged 1 commit into
python:3.9from
hugovk:backport-7747384-3.9

Conversation

hugovk commented Mar 19, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.
(cherry picked from commit 7747384)

Also updated tests to ignore the (new in 3.9) deprecation warnings, the same way they're ignored in 3.10.

https://bugs.python.org/issue47022

hugovk requested review from a team, tiran and vsajip as code owners March 19, 2022 21:03
bedevere-bot mentioned this pull request Mar 19, 2022
Merged
bedevere-bot added the docs Documentation in the Doc dir label Mar 19, 2022
hugovk requested a review from brettcannon March 19, 2022 21:39
brettcannon requested changes Mar 21, 2022
View reviewed changes
Comment thread Lib/asynchat.py Outdated

brettcannon Mar 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We can't backport warnings like this, only documentation.

hugovk Mar 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, dropped changes to .py files, and adjusted the NEWS entry to refer only to docs (and not deprecation warnings).

bedevere-bot commented Mar 21, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

brettcannon self-assigned this Mar 21, 2022
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
5419793 
…12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk force-pushed the backport-7747384-3.9 branch from 66e6bbf to 5419793 Compare March 22, 2022 09:05

hugovk commented Mar 22, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

bedevere-bot commented Mar 22, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

brettcannon merged commit af341eb into python:3.9 Mar 22, 2022
hugovk deleted the backport-7747384-3.9 branch March 22, 2022 18:16

bedevere-bot commented Mar 22, 2022

Copy link
Copy Markdown

@brettcannon: Please replace # with GH- in the commit message next time. Thanks!

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
bf720a3 
…12 (pythonGH-31891) (python#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
tiran Awaiting requested review from tiran
vsajip Awaiting requested review from vsajip

Assignees

brettcannon

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL