FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-29576: Improve some deprecations in the importlib by Carreau · Pull Request #32 · python/cpython · GitHub

/ cpython Public

bpo-29576: Improve some deprecations in the importlib - #32

Merged
brettcannon merged 2 commits into
python:masterfrom
Carreau:deprecations
Feb 16, 2017
ConversationCommits (2)ChecksFiles changed
Merged

bpo-29576: Improve some deprecations in the importlib#32
brettcannon merged 2 commits into
python:masterfrom
Carreau:deprecations

Conversation

Carreau commented Feb 12, 2017

Copy link
Copy Markdown
Contributor

Add the python version since the functionality is deprecated,
and raise a couple of deprecation warnings in a few places.

Theses functions are marked as deprecated in the documentation, but
especially in existing codebase, programmers tends to not re-check
whether functions are deprecated. So trigger the warning when possible.

It's also more probable that a developer will drop deprecated
functionality if we immediately give them information about
replacement API, and not have them to go find it in the documentation.

Include deprecation information in DocString as well, as many tools pull
documentation from there and not from docs.python.org.

fgregg reviewed Feb 12, 2017
View reviewed changes
Comment thread Lib/importlib/abc.py Outdated

fgregg Feb 12, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

typo here s/MetaPatFinder/MetaPathFinder/

Carreau Feb 12, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops indeed, thanks.

codecov Bot commented Feb 12, 2017

Copy link
Copy Markdown

Codecov Report

Merging #32 into master will decrease coverage by -0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   82.37%   82.36%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350951       +3     
==========================================
- Hits       289093   289062      -31     
- Misses      61855    61889      +34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22bfaa...58d8d3c. Read the comment docs.

brettcannon requested changes Feb 15, 2017
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add tests to make sure the warnings are being raised?

Comment thread Lib/importlib/abc.py Outdated

brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line is somewhat redundant since the deprecation is mentioned in the previous paragraph. Maybe just add the version it was deprecated in above?

Comment thread Lib/importlib/abc.py Outdated

brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The deprecation is mentioned in the above paragraph, so if you would like to add the version info just toss in up there.

Comment thread Lib/importlib/abc.py Outdated

brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add () after find_spec.

Comment thread Lib/importlib/abc.py Outdated

brettcannon Feb 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add() as appropriate.

Improve some deprecations in the importlib
51e8898 
Add the python version since the functionality is deprecated,
and raise a couple of deprecation warnings in a few places.

Theses functions are marked as deprecated in the documentation, but
especially in existing codebase, programmers tends to not re-check
whether functions are deprecated. So trigger the warning when possible.

It's also more probable that a developer will drop deprecated
functionality if we immediately give them information about
replacement API, and not have them to go find it in the documentation.

Include deprecation information in DocString as well as many tools pull
documentation from there and not from docs.python.org.

Add test making sure `find_loader()` and `find_module()` Both emit a
deprecation warning.

Carreau commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

All comments should be addressed.

brettcannon commented Feb 15, 2017

Copy link
Copy Markdown
Member

Thanks! Please add entries in Misc/NEWS and one in What's New in the "deprecated" section and this will be ready to be merged!

Carreau changed the title Improve some deprecations in the importlib bpo-29576: Improve some deprecations in the importlib Feb 16, 2017
brettcannon merged commit 1d4601c into python:master Feb 16, 2017

brettcannon commented Feb 16, 2017

Copy link
Copy Markdown
Member

Thanks!

Carreau deleted the deprecations branch February 16, 2017 02:05

Carreau commented Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

Thanks !

mdboom mentioned this pull request Aug 25, 2022
Closed
ziegenbalg mentioned this pull request Nov 30, 2022
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Set the task rate limit to 1 task per minute (GH-32)
375d8d1
jaraco pushed a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
Support text open(), though not by default (python#32)
8475c05 
Closes python#31
Fidget-Spinner referenced this pull request in pylbbv/pylbbv May 27, 2023
Fix: Bug in typeprop handling UNPACK_*, and bug in COPY_NO_INCREF (#32)
15aa9c1
gvanrossum mentioned this pull request Aug 22, 2023
Closed
LinanV mentioned this pull request Oct 23, 2023
Closed
stasos24 mentioned this pull request Oct 24, 2023
Closed
williamhu020 mentioned this pull request Nov 5, 2023
Closed
kcatss mentioned this pull request Nov 15, 2023
Closed
kcatss mentioned this pull request Jan 14, 2024
Closed
kcatss mentioned this pull request Feb 20, 2024
Closed
ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Closed
Closed
DominiquePACCO mentioned this pull request Jun 3, 2025
Closed
sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
Qanux mentioned this pull request Feb 11, 2026
Closed
ngoldbaum mentioned this pull request Mar 6, 2026
Closed
johng mentioned this pull request Jul 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
+1 more reviewer
fgregg fgregg left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL