FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-47127: Specialize calls for fastcall c functions with keywords by kumaraditya303 · Pull Request #32125 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-47127: Specialize calls for fastcall c functions with keywords - #32125

Merged
Fidget-Spinner merged 3 commits into
python:mainfrom
kumaraditya303:fastcall
Mar 27, 2022
ConversationCommits (3)ChecksFiles changed
Merged

bpo-47127: Specialize calls for fastcall c functions with keywords#32125
Fidget-Spinner merged 3 commits into
python:mainfrom
kumaraditya303:fastcall

Conversation

kumaraditya303 commented Mar 26, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Benchmark:

import pyperf

runner = pyperf.Runner()
runner.timeit(name="benchmark calls",
              stmt="a.decode();a.decode();a.decode();a.decode()",
              setup="a=b'a'*1000")

Result:

Mean +- std dev: [base] 2.16 us +- 0.12 us -> [patch] 1.68 us +- 0.06 us: 1.28x faster

It is the second largest specialization failure as per the stats.

https://bugs.python.org/issue47127

kumaraditya303 changed the title specialization for fastcall with keywords for c functions bpo-47127: Specialize call for fastcall c functions with keywords Mar 26, 2022
kumaraditya303 changed the title bpo-47127: Specialize call for fastcall c functions with keywords bpo-47127: Specialize calls for fastcall c functions with keywords Mar 26, 2022
kumaraditya303 marked this pull request as ready for review March 26, 2022 12:22
Fidget-Spinner approved these changes Mar 26, 2022
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Fidget-Spinner merged commit 58448cb into python:main Mar 27, 2022
kumaraditya303 deleted the fastcall branch March 28, 2022 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Fidget-Spinner Fidget-Spinner approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL