Repository navigation
bpo-47164: Argument Clinic uses _PyCFunction_CAST() - #32210
Merged
vstinner merged 1 commit intoMay 3, 2022
Merged
vstinner merged 1 commit into
vstinner merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
What to do with yet unmerged PRs that add Argument Clinic stuff (like #32010)? They'll introduce more (PyCFunction)(void(*)(void)). |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
You should ignore this draft PR for now. I'm still thinking about it :-) If there will be a conflict, I will simply regenerate this PR (rerun make clinic). |
Sorry, something went wrong.
Replace "(PyCFunction)(void(*)(void))func" cast with _PyCFunction_CAST(func).
vstinner
marked this pull request as ready for review
May 3, 2022 17:53
vstinner
requested review from
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
pganssle,
rhettinger and
tiran
as code owners
May 3, 2022 17:53
Copy link
Copy Markdown
Member
Author
|
I rebased my PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Example of change: - {"test_object_converter", (PyCFunction)(void(*)(void))test_object_converter, METH_FASTCALL, test_object_converter__doc__},
+ {"test_object_converter", _PyCFunction_CAST(test_object_converter), METH_FASTCALL, test_object_converter__doc__},
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "(PyCFunction)(void(*)(void))func" cast with
_PyCFunction_CAST(func).
https://bugs.python.org/issue47164