bpo-47189: What's New in 3.11: Faster CPython by Fidget-Spinner · Pull Request #32235 · python/cpython · GitHub

The static objects section's credits go to Kumar Aditya.

TODO:

Lazy __dict__ optimizations
[ ] dict memory saving optimizations by Inada-san, but I have no clue where to start for those

https://bugs.python.org/issue47189

Co-Authored-By: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

…snew

CC @gvanrossum @markshannon @brandtbucher @iritkatriel @sweeneyde @corona10 @kumaraditya303 @JelleZijlstra. For your opinions and review please (especially on the parts y'all contributed).

Thank you, It is a great honor to see my name on the list.

Thank you, It is a great honor to see my name on the list.

You deserve it.

Thanks for doing this. It is much appreciated.
I've left a few comments.

I would rather claim a range, say 10% to 60%.

Once the latest PRs are merged it will be about 25%, if you must have a single number.

https://gist.github.com/markshannon/bf1b99177290db30dd0ab8f56446d0ea

I will update this number when the benchmark link updates its values/ when those PRs are merged into main.

Co-Authored-By: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Co-Authored-By: Alex Waygood <Alex.Waygood@Gmail.com>

@pablogsal are you OK with this going into 3.11 whats new? Or would you prefer I host this somewhere else and link to it in the whatsnew?

@pablogsal are you OK with this going into 3.11 whats new? Or would you prefer I host this somewhere else and link to it in the whatsnew?

For the time leave it here in its own section as in this way I will be able to easily do the final edits. Removing or moving information is much easier to add it as that way I don't need to consider what may be missing :)

I put my nit-picking hat on while reviewing this. :-) Overall great work, and can't wait to see this show up on docs.python.org!

Is this an oblique reference to PRECALL_NO_KW_METHOD_DESCRIPTOR_O? Or does it refer to something else?

No, it just means that CALL_FUNCTION_EX for things like f(1, 2, *args, **kwargs) aren't inlined.

Hm. It's rather subtle what you intend to say then. The text linked under inline-calls already describes Python-to-Python calls. But they are described here again because specialization adds... what again? It feels like claiming credit for the same optimization in two places. I do realize that there are two separate code changes, but to the readers of a high-level document like this that seems a bit too subtle.

Also, it's not clear for what operation you are claiming a 170% speedup (so a factor 2.7). The table layout makes it look like C(arg). But surely the speedup for class constructors is not a single extremely large number?

Co-Authored-By: Guido van Rossum <gvanrossum@users.noreply.github.com> Co-Authored-By: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Bunch of one-character nits. :-)

Honestly this PR is so large and comments are flying so fast we should probably land it ASAP and then iterate.

Hm. It's rather subtle what you intend to say then. The text linked under inline-calls already describes Python-to-Python calls. But they are described here again because specialization adds... what again? It feels like claiming credit for the same optimization in two places. I do realize that there are two separate code changes, but to the readers of a high-level document like this that seems a bit too subtle.

Also, it's not clear for what operation you are claiming a 170% speedup (so a factor 2.7). The table layout makes it look like C(arg). But surely the speedup for class constructors is not a single extremely large number?

Co-Authored-By: Guido van Rossum <gvanrossum@users.noreply.github.com>

Also, it's not clear for what operation you are claiming a 170% speedup (so a factor 2.7). The table layout makes it look like C(arg). But surely the speedup for class constructors is not a single extremely large number?

Oof the table layout worked against me. The 170% speedup is tied to "Calls to certain python functions are inlined", not C(arg). I have since removed that line altogether.

Thanks, this looks good now. Thanks very much for all your work on this!

Fidget-Spinner and others added 7 commits March 8, 2022 22:51

Faster-cpython whatsnew initial draft

d18f804

Add section on static code objects/freezing imports

77701fe

Co-Authored-By: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

clarify where the benefits are

2d4171f

Add an FAQ section

2e7647f

Merge remote-tracking branch 'upstream/main' into faster_cpython_what…

7098375

…snew

Update FAQ, add performance figures and footnotes

07646a6

Merge remote-tracking branch 'upstream/main' into faster_cpython_what…

6436b81

…snew

bedevere-bot added the awaiting core review label Apr 1, 2022

the-knights-who-say-ni added the CLA signed label Apr 1, 2022

bedevere-bot added the docs Documentation in the Doc dir label Apr 1, 2022

Add NEWS

8063a44

Fidget-Spinner changed the title What's New in 3.11: Faster CPython bpo-47189: What's New in 3.11: Faster CPython Apr 1, 2022

Fix doc errors

33b0486

corona10 reviewed Apr 1, 2022

View reviewed changes

Add entry for namespace dictionar, make wording consistent

3cb89aa

JelleZijlstra reviewed Apr 1, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

markshannon reviewed Apr 1, 2022

View reviewed changes

Fidget-Spinner and others added 3 commits April 2, 2022 12:11

Apply suggestions by Mark and Jelle

121b24d

Co-Authored-By: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Credit Dennis Sweeney for STORE_SUBSCR

48dd46d

remove misleading sentence about memory usage and "hot" code

ff34d6f

kumaraditya303 reviewed Apr 2, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst Outdated

iritkatriel reviewed Apr 2, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst

Tighten wording, specify GCC

acef908

AlexWaygood reviewed Apr 2, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst Outdated

sweeneyde reviewed Apr 2, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst

Fidget-Spinner and others added 2 commits April 3, 2022 14:44

Apply suggestions by Alex

bc84c89

Co-Authored-By: Alex Waygood <Alex.Waygood@Gmail.com>

Remove outdated whatsnew section

1f1e565

gvanrossum reviewed Apr 5, 2022

View reviewed changes

iritkatriel reviewed Apr 5, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst

Fidget-Spinner and others added 2 commits April 5, 2022 18:54

Address Guido's and Irit's reviews

8b182ec

Co-Authored-By: Guido van Rossum <gvanrossum@users.noreply.github.com> Co-Authored-By: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

Remove "almost"

63fa529

pablogsal reviewed Apr 5, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst Outdated

Add Pablo's employer

f460c93

gvanrossum reviewed Apr 5, 2022

View reviewed changes

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

Comment thread Doc/whatsnew/3.11.rst Outdated

gvanrossum reviewed Apr 5, 2022

View reviewed changes

Address Guido's review

584dafa

Co-Authored-By: Guido van Rossum <gvanrossum@users.noreply.github.com>

gvanrossum approved these changes Apr 6, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Apr 6, 2022

Fidget-Spinner merged commit 9ffe47d into python:main Apr 6, 2022

bedevere-bot removed the awaiting merge label Apr 6, 2022

Fidget-Spinner deleted the faster_cpython_whatsnew branch April 6, 2022 11:38

Fidget-Spinner mentioned this pull request May 9, 2022

What's new in Python 3.11: Faster CPython #91345

Closed

               .. This section singles out the most important changes in Python 3.11.
                  Brevity is key.
+              - Python 3.11 is 22% faster than Python 3.10. See `Faster CPython`_ for details.

		\| \| \| Calls to certain Python functions are inlined similar \| \| \|
		\| \| \| to :ref:`inline-calls`. \| \| \|

bpo-47189: What's New in 3.11: Faster CPython by Fidget-Spinner · Pull Request #32235 · python/cpython · GitHub

Repository navigation

bpo-47189: What's New in 3.11: Faster CPython - #32235

bpo-47189: What's New in 3.11: Faster CPython#32235Fidget-Spinner merged 20 commits intopython:mainpython/cpython:mainfrom Fidget-Spinner:faster_cpython_whatsnewFidget-Spinner/cpython:faster_cpython_whatsnewCopy head branch name to clipboard

Conversation

Fidget-Spinner commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fidget-Spinner commented Apr 1, 2022

Uh oh!

corona10 left a comment

Choose a reason for hiding this comment

Uh oh!

markshannon commented Apr 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

markshannon left a comment

Choose a reason for hiding this comment

Uh oh!

markshannon Apr 1, 2022

Choose a reason for hiding this comment

Uh oh!

Fidget-Spinner Apr 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Fidget-Spinner commented Apr 4, 2022

Uh oh!

pablogsal commented Apr 4, 2022

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum Apr 5, 2022

Choose a reason for hiding this comment

Uh oh!

Fidget-Spinner Apr 5, 2022

Choose a reason for hiding this comment

Uh oh!

gvanrossum Apr 5, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Apr 5, 2022

Choose a reason for hiding this comment

bpo-47189: What's New in 3.11: Faster CPython#32235
Fidget-Spinner merged 20 commits into
python:mainfrom
Fidget-Spinner:faster_cpython_whatsnew

Fidget-Spinner commented Apr 1, 2022 •
edited
Loading

Fidget-Spinner commented Apr 6, 2022 •
edited
Loading