FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91372: add mtime to gzip.open by ellaellela · Pull Request #32310 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-91372: add mtime to gzip.open - #32310

Merged
serhiy-storchaka merged 16 commits into
python:mainfrom
ellaellela:add-mtime-to-gzip-open
May 22, 2026
ConversationCommits (16)ChecksFiles changed
Merged

gh-91372: add mtime to gzip.open#32310
serhiy-storchaka merged 16 commits into
python:mainfrom
ellaellela:add-mtime-to-gzip-open

Conversation

ellaellela commented Apr 4, 2022 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

AlexWaygood added the type-feature A feature request or enhancement label Apr 4, 2022
MaxwellDupre approved these changes Apr 23, 2022
View reviewed changes

MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ran 64 tests in 1.929s
OK (skipped=1)
Looks ok.

carlbordum commented May 11, 2022

Copy link
Copy Markdown
Contributor

Also looks good to me^

ellaellela mannequin mentioned this pull request Apr 10, 2022
Closed
serhiy-storchaka requested changes Feb 23, 2024
View reviewed changes
Comment thread Lib/test/test_gzip.py Outdated
Comment thread Lib/gzip.py Outdated

bedevere-app Bot commented Feb 23, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

AlexWaygood changed the title bpo-47216: add mtime to gzip.open gh-91372: add mtime to gzip.open Feb 23, 2024

ellaellela commented Mar 30, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

bedevere-app Bot commented Mar 30, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

bedevere-app Bot requested a review from serhiy-storchaka March 30, 2024 11:08

python-cla-bot Bot commented Apr 18, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 10, 2026

serhiy-storchaka commented May 20, 2026

Copy link
Copy Markdown
Member

@ellaellela, can you please sign the CLA? Otherwise we will be forced to reject this PR.

serhiy-storchaka added the pending The issue will be closed if no feedback is provided label May 20, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 20, 2026

ellaellela commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka: signed it. Thx. I will rebase the PR to the newest main now. Should I remove changes from Doc/whatsnew/3.13.rst to Doc/whatsnew/3.16.rst regarding the changes to the library?

read-the-docs-community Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32808846 | 📁 Comparing 962e598 against main (f159419)

  🔍 Preview build  

3 files changed
± library/gzip.html
± whatsnew/3.16.html
± whatsnew/changelog.html

ellaellela requested a review from AA-Turner as a code owner May 22, 2026 07:20
serhiy-storchaka reviewed May 22, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Few suggestions on formatting and documentation.

Comment thread Doc/whatsnew/3.16.rst Outdated
Comment thread Lib/gzip.py Outdated
Comment thread Misc/NEWS.d/next/Library/2022-04-04-17-58-05.bpo-47216.gPyPte.rst Outdated
Comment thread Doc/library/gzip.rst
ellaellela and others added 2 commits May 22, 2026 11:57
serhiy-storchaka reviewed May 22, 2026
View reviewed changes
Comment thread Doc/library/gzip.rst Outdated
Comment thread Doc/library/gzip.rst Outdated
ellaellela and others added 2 commits May 22, 2026 12:42
Reviewer's doc improvements.
ab6ba39 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Reviewer's improvements.
33d07f4
serhiy-storchaka approved these changes May 22, 2026
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. 👍

serhiy-storchaka merged commit cf5c8c5 into python:main May 22, 2026
55 of 56 checks passed

serhiy-storchaka commented May 22, 2026

Copy link
Copy Markdown
Member

Thank you for your contribution @ellaellela.

ellaellela deleted the add-mtime-to-gzip-open branch May 22, 2026 12:38

ellaellela commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Anytime :)

grantlouisherman pushed a commit to grantlouisherman/cpython that referenced this pull request May 22, 2026
pythongh-91372: Add mtime to gzip.open() (pythonGH-32310)
344f35d
grantlouisherman pushed a commit to grantlouisherman/cpython that referenced this pull request May 22, 2026
pythongh-91372: Add mtime to gzip.open() (pythonGH-32310)
808ea13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
+1 more reviewer
MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pending The issue will be closed if no feedback is provided type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL