bpo-35134: Remove the Include/code.h header file - #32385
Merged
vstinner merged 2 commits intoApr 7, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
vstinner
requested review from
a team,
iritkatriel,
markshannon and
tiran
as code owners
April 6, 2022 22:58
Copy link
Copy Markdown
Member
Author
|
None of the top 5000 PyPI projects include directly code.h: $ ./search_pypi_top.py PYPI-2022-01-26-TOP-5000/ '# *include [<"]code.h[">]' -q PYPI-2022-01-26-TOP-5000/Pygments-2.11.2.tar.gz: Pygments-2.11.2/tests/examplefiles/c/ceval.c: #include "code.h" PYPI-2022-01-26-TOP-5000/typed_ast-1.5.2.tar.gz: typed_ast-1.5.2/ast27/Include/compile.h: #include "code.h" Found 2 matching lines in 2 projects
|
Sorry, something went wrong.
Remove the Include/code.h header file. C extensions should only include the main <Python.h> header file. Python.h includes directly Include/cpython/code.h instead.
tacaswell
added a commit
to tacaswell/typed_ast
that referenced
this pull request
May 10, 2022
As of python/cpython#32385 the header code.h is private but directly included into Python.h
hauntsaninja
pushed a commit
to python/typed_ast
that referenced
this pull request
May 10, 2022
As of python/cpython#32385 the header code.h is private but directly included into Python.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Include/code.h header file. C extensions should only
include the main <Python.h> header file.
Python.h includes directly Include/cpython/code.h instead.
https://bugs.python.org/issue35134