FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

closes bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might be NULL by benjaminp · Pull Request #3329 · python/cpython · GitHub

/ cpython Public

closes bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might be NULL - #3329

Merged
benjaminp merged 1 commit into
masterfrom
benjamin-null-memcpy
Sep 5, 2017
Merged

closes bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might be NULL#3329
benjaminp merged 1 commit into
masterfrom
benjamin-null-memcpy

Conversation

benjaminp commented Sep 4, 2017
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Passing NULL as the second argument to to memcpy is undefined behavior even if the size is 0.

https://bugs.python.org/issue31347

…ht not be null

Passing NULL as the second argument to to memcpy is undefined behavior even if the size is 0.
benjaminp requested a review from vstinner September 4, 2017 23:35
benjaminp changed the title bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might be NULL closes bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might be NULL Sep 4, 2017

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

benjaminp merged commit a3070d5 into master Sep 5, 2017
benjaminp deleted the benjamin-null-memcpy branch September 5, 2017 05:23
jimmylai pushed a commit to jimmylai/cpython that referenced this pull request Sep 5, 2017
* 'master' of https://github.com/python/cpython: (32 commits)
  Conceptually, roots is a set.  Also searching it as a set is a tiny bit faster (python#3338)
  bpo-31343: Include sys/sysmacros.h (python#3318)
  bpo-30102: Call OPENSSL_add_all_algorithms_noconf (python#3112)
  Prevent a few make suspicious warnings. (python#3341)
  Include additional changes to support blurbified NEWS (python#3340)
  Simplify NEWS entry to prevent suspicious warnings. (python#3339)
  bpo-31347: _PyObject_FastCall_Prepend: do not call memcpy if args might not be null (python#3329)
  Revert "bpo-17852: Maintain a list of BufferedWriter objects.  Flush them on exit. (python#1908)" (python#3337)
  bpo-17852: Maintain a list of BufferedWriter objects.  Flush them on exit. (python#1908)
  Fix terminology in comment and add more design rationale. (python#3335)
  Add comment to explain the implications of not sorting keywords (python#3331)
  bpo-31170: Update libexpat from 2.2.3 to 2.2.4 (python#3315)
  bpo-28411: Remove "modules" field from Py_InterpreterState. (python#1638)
  random_triangular:  sqrt() is more accurate than **0.5 (python#3317)
  Travis: use ccache (python#3307)
  remove IRIX support (closes bpo-31341) (python#3310)
  Code clean-up.  Remove unnecessary pre-increment before the loop starts. (python#3312)
  Regen Moduls/clinic/_ssl.c.h (pythonGH-3320)
  bpo-30502: Fix handling of long oids in ssl. (python#2909)
  Cache externals, depending on changes to PCbuild (python#3308)
  ...
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
…ht not be null (python#3329)

Passing NULL as the second argument to to memcpy is undefined behavior even if the size is 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL