| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| On 64bit Linux systems that use ``$prefix/lib64``, this is now the default | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityThis is not specific to Linux.
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityUnix then?
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityUnix-like?
Sorry, something went wrong.
All reactions
|
||
| install location for the standard library. Python will still be able to | ||
| import modules installed in ``$prefix/lib``. | ||
|
|
||
| #.. section: Windows #.. section: macOS #.. section: IDLE #.. section: | ||
| Tools/Demos #.. section: C API | ||
|
|
||
| # Write your Misc/NEWS entry below. It should be a simple ReST paragraph. # | ||
| Don't start with "- Issue #<n>: " or "- bpo-<n>: " or that sort of stuff. | ||
| ########################################################################### | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| Introduce a ``platsubdir`` sysconfig variable that contains the name of the | ||
| platform-specific "lib" directory. This is used to construct paths that do | ||
| not differ by prefix, i.e., ``/usr/lib`` vs ``/usr/lib64``. The | ||
| ``posix_prefix`` install scheme is changed to take this into account. | ||
|
|
||
| By default, this is ``basename $libdir``, but can be overriden by | ||
| ``./configure --with-custom-platsubdir``. | ||
|
|
||
| #.. section: Documentation #.. section: Tests .. section: Build | ||
|
|
||
| On 64bit Linux systems that use ``$prefix/lib64``, this is now the default | ||
| install location for the standard library. Python will still be able to | ||
| import modules installed in ``$prefix/lib``. | ||
|
|
||
| #.. section: Windows #.. section: macOS #.. section: IDLE #.. section: | ||
| Tools/Demos #.. section: C API | ||
|
|
||
| # Write your Misc/NEWS entry below. It should be a simple ReST paragraph. # | ||
| Don't start with "- Issue #<n>: " or "- bpo-<n>: " or that sort of stuff. | ||
| ########################################################################### |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -4587,12 +4587,26 @@ AC_MSG_CHECKING(LDVERSION) | |
| LDVERSION='$(VERSION)$(ABIFLAGS)' | ||
| AC_MSG_RESULT($LDVERSION) | ||
|
|
||
| # platsubdir must be defined before LIBPL definition | ||
| AC_MSG_CHECKING(for custom platsubdir) | ||
| AC_ARG_WITH(custom-platsubdir, | ||
| [AS_HELP_STRING([--with-custom-platsubdir=<libdirname>], | ||
|
Comment thread
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityinstead of --with-custom... just use --with. Also this is more commonly called --with-libdir
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualitythe whole point of the PR is that this is distinct from (how Python uses) libdir
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityokay, I've finally had a chance to re-read the original bug and this code. I'm not the biggest fan of introducing Yet Another variable and would prefer to fix how libdir gets used, but that seems like a bigger and more invasive change. Lets at least remove the custom portion of the name. While I likely won't get to this for some time, it might be worth a more general conversation about what tunables we offer in configure, what they mean, and how they get used.
Sorry, something went wrong.
All reactions
|
||
| [name of the platform-specific lib subdirectory of $prefix. This is usually "lib", "lib32" or "lib64". Defaults to basename($libdir)])], | ||
| [], | ||
| [with_custom_platsubdir=yes]) | ||
| AS_CASE($with_custom_platsubdir, | ||
| [yes],[platsubdir=`basename ${libdir}`], | ||
| [no],[platsubdir=lib], | ||
| [platsubdir=$with_custom_platsubdir]) | ||
| AC_MSG_RESULT($platsubdir) | ||
| AC_SUBST(platsubdir) | ||
|
|
||
| dnl define LIBPL after ABIFLAGS and LDVERSION is defined. | ||
| AC_SUBST(PY_ENABLE_SHARED) | ||
| if test x$PLATFORM_TRIPLET = x; then | ||
| LIBPL='$(prefix)'"/lib/python${VERSION}/config-${LDVERSION}" | ||
| LIBPL='$(prefix)'"/${platsubdir}/python${VERSION}/config-${LDVERSION}" | ||
| else | ||
| LIBPL='$(prefix)'"/lib/python${VERSION}/config-${LDVERSION}-${PLATFORM_TRIPLET}" | ||
| LIBPL='$(prefix)'"/${platsubdir}/python${VERSION}/config-${LDVERSION}-${PLATFORM_TRIPLET}" | ||
| fi | ||
| AC_SUBST(LIBPL) | ||
|
|
||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI don't like how we're special casing "lib" here. I'd prefer to always take the same code path and use some special token that gets replaced.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualitythis is the same thing the code did before though.
i suppose we could introduce puresubdir as the other option and prefill it to lib somewhere, is that what you're suggesting?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Qualityhm, no, i misread which part of the code you're commenting. sorry.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.