bpo-32787: Better error handling in ctypes. - #3727
Merged
serhiy-storchaka merged 11 commits intoDec 5, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
eric-wieser
reviewed
Feb 7, 2018
Comment thread
Modules/_ctypes/stgdict.c
| } | ||
|
|
||
| len = PySequence_Length(fields); | ||
| len = PySequence_Size(fields); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why Length → Size?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
PySequence_Size is more commonly used. PySequence_Length is just an outdated alias of PySequence_Size.
Sorry, something went wrong.
Copy link
Copy Markdown
|
@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32787