Repository navigation
require uuid_generate_time_safe for all tests of it - #390
Merged
benjaminp merged 1 commit intoMar 2, 2017
Merged
benjaminp merged 1 commit into
benjaminp merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The way mocking is written in these tests, we need to have the underlying function around.
Copy link
Copy Markdown
Member
|
@benjaminp Thanks for taking a look at this. Sorry 8 hours in the middle of USA night really isn't enough time to review it though. Did this fix an actual bug you encountered, and if so what was the failure mode? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I didn't expect you to review this at 2:30 AM EST; I just wanted to let you know. The problem is the tests were not properly skipped as intended, so one had, for example, on Windows:
======================================================================
ERROR: test_uuid1_bogus_return_value (test.test_uuid.TestUUID)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_uuid.py", line 379, in test_uuid1_bogus_return_value
'restype', lambda x: 3):
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1239, in __enter__
original, local = self.get_original()
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1213, in get_original
"%s does not have the attribute %r" % (target, name)
AttributeError: None does not have the attribute 'restype'
======================================================================
ERROR: test_uuid1_is_safe (test.test_uuid.TestUUID)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_uuid.py", line 365, in test_uuid1_is_safe
'restype', lambda x: 0):
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1239, in __enter__
original, local = self.get_original()
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1213, in get_original
"%s does not have the attribute %r" % (target, name)
AttributeError: None does not have the attribute 'restype'
======================================================================
ERROR: test_uuid1_is_unsafe (test.test_uuid.TestUUID)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_uuid.py", line 372, in test_uuid1_is_unsafe
'restype', lambda x: -1):
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1239, in __enter__
original, local = self.get_original()
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1213, in get_original
"%s does not have the attribute %r" % (target, name)
AttributeError: None does not have the attribute 'restype'
======================================================================
ERROR: test_uuid1_unknown (test.test_uuid.TestUUID)
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\buildarea\3.x.ware-win81-release\build\lib\test\test_uuid.py", line 358, in test_uuid1_unknown
'restype', None):
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1239, in __enter__
original, local = self.get_original()
File "D:\buildarea\3.x.ware-win81-release\build\lib\unittest\mock.py", line 1213, in get_original
"%s does not have the attribute %r" % (target, name)
AttributeError: None does not have the attribute 'restype'
----------------------------------------------------------------------
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's all good! Thanks for the additional details... and the fix. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way mocking is written in these tests, we need to have the underlying function around.