Repository navigation
bpo-31779: Prevent assertion failures and a crash when using an uninitialized struct.Struct object - #3984
Closed
orenmn wants to merge 5 commits into
Closed
bpo-31779: Prevent assertion failures and a crash when using an uninitialized struct.Struct object#3984orenmn wants to merge 5 commits into
orenmn wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
pppery
reviewed
Sep 16, 2018
Comment thread
Lib/test/test_struct.py
| s2 = struct.Struct(s.format.encode()) | ||
| self.assertEqual(s2.format, s.format) | ||
|
|
||
| @support.cpython_only |
Copy link
Copy Markdown
There was a problem hiding this comment.
Why is this test cpython only?
Sorry, something went wrong.
Copy link
Copy Markdown
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
MaxwellDupre
suggested changes
Mar 29, 2022
MaxwellDupre
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good:
struct_obj.iter_unpack(b'foo')
Traceback (most recent call last):
File "", line 1, in
ValueError: Struct.init() wasn't called
Can you respond to:
pppery on 16 Sep 2018
Why is this test cpython only?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition, add tests to test_struct to make sure the assertion failures and the crash are no more.
https://bugs.python.org/issue31779