FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-31802: Fix importing native path module before importing os. by serhiy-storchaka · Pull Request #4017 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-31802: Fix importing native path module before importing os. - #4017

Merged
serhiy-storchaka merged 5 commits into
python:masterfrom
serhiy-storchaka:native-os-path-cycle-import
Jan 7, 2018
ConversationCommits (5)ChecksFiles changed
Merged

bpo-31802: Fix importing native path module before importing os.#4017
serhiy-storchaka merged 5 commits into
python:masterfrom
serhiy-storchaka:native-os-path-cycle-import

Conversation

serhiy-storchaka commented Oct 17, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Oct 17, 2017
zware requested changes Jan 7, 2018
View reviewed changes
Comment thread Lib/test/test_genericpath.py Outdated
self.pathmodule.relpath(bytearray(b'foo'), bytearray(b'bar'))

def test_import(self):
support.script_helper.assert_python_ok(

zware Jan 7, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

support.script_helper needs to be imported.

bedevere-bot commented Jan 7, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

serhiy-storchaka commented Jan 7, 2018

Copy link
Copy Markdown
Member Author

Thanks @zware! I have made the requested changes; please review again.

bedevere-bot commented Jan 7, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

serhiy-storchaka merged commit 3460198 into python:master Jan 7, 2018

miss-islington commented Jan 7, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

serhiy-storchaka deleted the native-os-path-cycle-import branch January 7, 2018 15:54
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 7, 2018
bpo-31802: Fix importing native path module before importing os. (pyt…
b2f7691 
…honGH-4017)

(cherry picked from commit 3460198)

bedevere-bot commented Jan 7, 2018

Copy link
Copy Markdown

GH-5129 is a backport of this pull request to the 3.6 branch.

miss-islington commented Jan 7, 2018

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3460198f6ba40a839f105c381f07179aba1e8c61 2.7

serhiy-storchaka pushed a commit that referenced this pull request Jan 7, 2018
bpo-31802: Fix importing native path module before importing os. (GH-…
94a3fac 
…4017) (#5129)

(cherry picked from commit 3460198)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zware zware approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL